You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/14 12:49:47 UTC
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #4083: Allow set IPv6 when deploying advanced network Zone with SG via UI
GabrielBrascher opened a new pull request #4083:
URL: https://github.com/apache/cloudstack/pull/4083
## Description
<!--- Describe your changes in detail -->
Advanced Network with Security Groups is a great option for deploying a Zone with IPv6 address support. However, it is not possible to set **IPv6 DNS** + **IPv6 CIDR** + **IPv6 gateway** via the zoneWizard UI.
Currently, the workaround is to either (i) create a new network (the default guest network would not support IPv6), (ii) deploy a zone via API, or (iii) to run a MySQL update query to set the default guest network IPv6 config.
This PR adds a small enhancement on the UI Zone deployment to allow deploying a Zone with Advanced Network with Security Groups + IPv6 CIDR, IPv6 gateway, and IPv6 DNS.
Note that API offers full support for such action, therefore there is no need for changing the API. It is just a small enhancement on UI that might be useful in the meantime that we wait for the new ACS UI.
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
1. Create a new Zone with advanced network and security groups
2. Configure ipv6 dns, ipv6 cidr, and ipv6 gateway
3. Check that guest network has been created as expected
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4083: Allow set IPv6 when deploying advanced network Zone with SG via UI
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4083:
URL: https://github.com/apache/cloudstack/pull/4083#issuecomment-628614953
Assuming you want this in 4.15, @GabrielBrascher ; can you provide a primate PR, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4083: Allow set IPv6 when deploying advanced network Zone with SG via UI
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4083:
URL: https://github.com/apache/cloudstack/pull/4083
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4083: Allow set IPv6 when deploying advanced network Zone with SG via UI
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4083:
URL: https://github.com/apache/cloudstack/pull/4083#issuecomment-628617437
You are right @DaanHoogland, this will be for 4.15 (maybe 4.14.1, but I am considering this more a enhancement than a bugfix).
Sure, I will check how I can add this to primate and ensure that we have proper IPv6 support there as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4083: Allow set IPv6 when deploying advanced network Zone with SG via UI
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4083:
URL: https://github.com/apache/cloudstack/pull/4083#issuecomment-628621323
@GabrielBrascher can you check and send PR to https://github.com/apache/cloudstack-primate as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4083: Allow set IPv6 when deploying advanced network Zone with SG via UI
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4083:
URL: https://github.com/apache/cloudstack/pull/4083#issuecomment-630170389
@rhtyd just linking the Draft PR [#343](https://github.com/apache/cloudstack-primate/pull/343) created at the CloudStack Primate project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org