You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/04/01 23:00:07 UTC

[GitHub] [druid] techdocsmith commented on a change in pull request #11056: Add paramter to loadstatus API to compute underdeplication against cluster view

techdocsmith commented on a change in pull request #11056:
URL: https://github.com/apache/druid/pull/11056#discussion_r605987115



##########
File path: docs/operations/api-reference.md
##########
@@ -102,6 +102,15 @@ Returns the number of segments left to load until segments that should be loaded
 
 Returns the number of segments left to load in each tier until segments that should be loaded in the cluster are all available. This includes segment replication counts.
 
+* `/druid/coordinator/v1/loadstatus?full?computeUsingClusterView`
+
+Returns the number of segments left to load in each tier until segments that should be loaded in the cluster are all available.

Review comment:
       ```suggestion
   Returns the number of segments not yet loaded for each tier until all segments to load in the cluster are available.
   ```

##########
File path: docs/operations/api-reference.md
##########
@@ -102,6 +102,15 @@ Returns the number of segments left to load until segments that should be loaded
 
 Returns the number of segments left to load in each tier until segments that should be loaded in the cluster are all available. This includes segment replication counts.
 
+* `/druid/coordinator/v1/loadstatus?full?computeUsingClusterView`
+
+Returns the number of segments left to load in each tier until segments that should be loaded in the cluster are all available.
+This includes segment replication counts. When computing the number of segments left to load, the number of nodes

Review comment:
       ```suggestion
   The result includes segment replication counts. It also factors in the number of available nodes that are of a service type that can load the segment when computing the number of segments remaining to load.
   ```

##########
File path: docs/operations/api-reference.md
##########
@@ -102,6 +102,15 @@ Returns the number of segments left to load until segments that should be loaded
 
 Returns the number of segments left to load in each tier until segments that should be loaded in the cluster are all available. This includes segment replication counts.
 
+* `/druid/coordinator/v1/loadstatus?full?computeUsingClusterView`
+
+Returns the number of segments left to load in each tier until segments that should be loaded in the cluster are all available.
+This includes segment replication counts. When computing the number of segments left to load, the number of nodes
+available in the cluster that are of a service type that can load the segment is considered. A segment is considered fully
+loaded if it is replicated as many times as configured in the corresponding load rule, or if there are as many replicas of
+the segment in each tier where the segment is configured to be replicated, as there are available nodes in the tier at the

Review comment:
       ```suggestion
   
   ```

##########
File path: docs/operations/api-reference.md
##########
@@ -102,6 +102,15 @@ Returns the number of segments left to load until segments that should be loaded
 
 Returns the number of segments left to load in each tier until segments that should be loaded in the cluster are all available. This includes segment replication counts.
 
+* `/druid/coordinator/v1/loadstatus?full?computeUsingClusterView`
+
+Returns the number of segments left to load in each tier until segments that should be loaded in the cluster are all available.
+This includes segment replication counts. When computing the number of segments left to load, the number of nodes
+available in the cluster that are of a service type that can load the segment is considered. A segment is considered fully
+loaded if it is replicated as many times as configured in the corresponding load rule, or if there are as many replicas of

Review comment:
       ```suggestion
   - Druid had replicated it the number of times configured in the corresponding load rule.
   - Or the number of replicas for the segment in each tier where it configured to be replicated equals the available nodes of a service type that are currently allowed to load the segment in the tier.
   ```

##########
File path: docs/operations/api-reference.md
##########
@@ -102,6 +102,15 @@ Returns the number of segments left to load until segments that should be loaded
 
 Returns the number of segments left to load in each tier until segments that should be loaded in the cluster are all available. This includes segment replication counts.
 
+* `/druid/coordinator/v1/loadstatus?full?computeUsingClusterView`
+
+Returns the number of segments left to load in each tier until segments that should be loaded in the cluster are all available.
+This includes segment replication counts. When computing the number of segments left to load, the number of nodes
+available in the cluster that are of a service type that can load the segment is considered. A segment is considered fully

Review comment:
       ```suggestion
   A segment is considered fully loaded when:
   ```

##########
File path: docs/operations/api-reference.md
##########
@@ -102,6 +102,15 @@ Returns the number of segments left to load until segments that should be loaded
 
 Returns the number of segments left to load in each tier until segments that should be loaded in the cluster are all available. This includes segment replication counts.
 
+* `/druid/coordinator/v1/loadstatus?full?computeUsingClusterView`
+
+Returns the number of segments left to load in each tier until segments that should be loaded in the cluster are all available.
+This includes segment replication counts. When computing the number of segments left to load, the number of nodes
+available in the cluster that are of a service type that can load the segment is considered. A segment is considered fully
+loaded if it is replicated as many times as configured in the corresponding load rule, or if there are as many replicas of
+the segment in each tier where the segment is configured to be replicated, as there are available nodes in the tier at the
+current time that are of a service type that is allowed to load the segment.

Review comment:
       ```suggestion
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org