You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/02 18:23:13 UTC

[GitHub] [beam] damondouglas commented on pull request #22817: Implement KafkaSchemaTransformWriteConfiguration

damondouglas commented on PR #22817:
URL: https://github.com/apache/beam/pull/22817#issuecomment-1235789913

   > * Should users be able to specify whether they want to serialize their data into Avro / JSON / something else?
   
   Would the `getValueSerializer` inform the SchemaTransform whether it is Avro / Json or something else?
   
   > * We will have a PCollection as input, right? - how will users decide which is the key for the messages produced?
   
   Would the `getKeySerializer` inform the SchemaTransform how to write the Key data?
   
   If both are true, then I wonder if we need to remove the `@Nullable` annotation from `getValueSerializer` and `getKeySerializer`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org