You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tianyi Wang (Code Review)" <ge...@cloudera.org> on 2018/07/30 18:09:16 UTC
[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11079
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
......................................................................
IMPALA-7258: Support querying HBase tables in LocalCatalog
This is a straightforward porting expecting no behavior change. All of
the HBase E2E tests passes with this patch.
Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddReplaceColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
A fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java
M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
A fe/src/main/java/org/apache/impala/catalog/local/LocalHbaseTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/planner/TableSink.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
21 files changed, 892 insertions(+), 737 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/11079/1
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11079 )
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
......................................................................
Patch Set 2:
(15 comments)
mostly minor comments, otherwise, looks fine.
http://gerrit.cloudera.org:8080/#/c/11079/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11079/2//COMMIT_MSG@9
PS2, Line 9: porting
nit: port
http://gerrit.cloudera.org:8080/#/c/11079/2//COMMIT_MSG@10
PS2, Line 10: passes
nit: pass
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java:
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java@26
PS2, Line 26: import org.apache.impala.catalog.HBaseTable;
remove
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java:
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java@23
PS2, Line 23: import org.apache.impala.catalog.HBaseTable;
remove
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java:
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java@23
PS2, Line 23: import org.apache.impala.catalog.HBaseTable;
remove
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java:
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@33
PS2, Line 33: import org.apache.impala.catalog.HBaseTable;
remove
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java:
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java@26
PS2, Line 26: import org.apache.impala.catalog.HBaseTable;
remove
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@50
PS2, Line 50: import org.apache.impala.catalog.HBaseTable;
remove
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java:
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@35
PS2, Line 35: import org.apache.impala.catalog.HBaseTable;
remove
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
File fe/src/main/java/org/apache/impala/catalog/HBaseTable.java:
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java@50
PS2, Line 50: Input format class for HBase tables read by Hive.
move this comment before L51, then bring the "implements" up a line.
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java:
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java@55
PS2, Line 55: import org.apache.tools.ant.taskdefs.Local;
remove (ide expansion?)
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
File fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java:
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java@40
PS2, Line 40: import org.apache.impala.catalog.HBaseTable;
remove
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/Planner.java
File fe/src/main/java/org/apache/impala/planner/Planner.java:
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/Planner.java@38
PS2, Line 38: import org.apache.impala.catalog.HBaseTable;
remove
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java:
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@62
PS2, Line 62: import org.apache.impala.catalog.HBaseTable;
remove
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:
http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/service/Frontend.java@88
PS2, Line 88: import org.apache.impala.catalog.HBaseTable;
remove
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Aug 2018 23:19:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11079 )
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
......................................................................
IMPALA-7258: Support querying HBase tables in LocalCatalog
This is a straightforward port expecting no behavior change. All of
the HBase E2E tests pass with this patch.
Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Reviewed-on: http://gerrit.cloudera.org:8080/11079
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddReplaceColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
A fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java
M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
A fe/src/main/java/org/apache/impala/catalog/local/LocalHbaseTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/planner/TableSink.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
20 files changed, 923 insertions(+), 750 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 6
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11079 )
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/170/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:28:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11079 )
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
......................................................................
Patch Set 1:
(7 comments)
Looks good. The way that hbase tables fetch stats is definitely going to need some caching when we get there! :)
http://gerrit.cloudera.org:8080/#/c/11079/1/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java
File fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java:
http://gerrit.cloudera.org:8080/#/c/11079/1/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java@1
PS1, Line 1: package org.apache.impala.catalog;
nit: add license header
http://gerrit.cloudera.org:8080/#/c/11079/1/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java@84
PS1, Line 84: hbaseConf_
nit: should be named like a constant
also: seems "static final" is more commonly used than "final static"
http://gerrit.cloudera.org:8080/#/c/11079/1/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java@343
PS1, Line 343: FeHBaseTable tbl
nit: in the other Util classes, I put the table instance as the first param instead of the last, let's keep it that way for consistency
http://gerrit.cloudera.org:8080/#/c/11079/1/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
File fe/src/main/java/org/apache/impala/catalog/HBaseTable.java:
http://gerrit.cloudera.org:8080/#/c/11079/1/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java@134
PS1, Line 134: " + "
nit: weird formatting
http://gerrit.cloudera.org:8080/#/c/11079/1/fe/src/main/java/org/apache/impala/catalog/local/LocalHbaseTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalHbaseTable.java:
http://gerrit.cloudera.org:8080/#/c/11079/1/fe/src/main/java/org/apache/impala/catalog/local/LocalHbaseTable.java@1
PS1, Line 1: package org.apache.impala.catalog.local;
nit: license header
http://gerrit.cloudera.org:8080/#/c/11079/1/fe/src/main/java/org/apache/impala/catalog/local/LocalHbaseTable.java@25
PS1, Line 25: sta
nit: typo
http://gerrit.cloudera.org:8080/#/c/11079/1/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java:
http://gerrit.cloudera.org:8080/#/c/11079/1/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@77
PS1, Line 77: // TODO(todd) support HBase table
oops, can remove this and the other TODO on line 80
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Jul 2018 19:16:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11079 )
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
......................................................................
IMPALA-7258: Support querying HBase tables in LocalCatalog
This is a straightforward port expecting no behavior change. All of
the HBase E2E tests pass with this patch.
Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddReplaceColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
A fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java
M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
A fe/src/main/java/org/apache/impala/catalog/local/LocalHbaseTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/planner/TableSink.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
20 files changed, 922 insertions(+), 750 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/11079/3
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11079 )
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Aug 2018 15:15:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11079 )
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
......................................................................
Patch Set 3:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/169/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Aug 2018 00:50:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11079 )
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
......................................................................
IMPALA-7258: Support querying HBase tables in LocalCatalog
This is a straightforward port expecting no behavior change. All of
the HBase E2E tests pass with this patch.
Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddReplaceColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
A fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java
M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
A fe/src/main/java/org/apache/impala/catalog/local/LocalHbaseTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/planner/TableSink.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
20 files changed, 923 insertions(+), 750 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/11079/4
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11079 )
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
......................................................................
Patch Set 1:
No Builds Executed
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Jul 2018 22:34:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11079 )
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 5
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Aug 2018 19:03:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11079 )
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 5
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Aug 2018 22:05:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11079 )
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/123/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Aug 2018 01:10:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11079 )
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2929/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 5
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Aug 2018 19:03:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11079 )
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/11079/3/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java:
http://gerrit.cloudera.org:8080/#/c/11079/3/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@220
PS3, Line 220: int startColIdx = (table_ instanceof FeHBaseTable) ? 0 : table_.getNumClusteringCols();
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/11079/3/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java
File fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java:
http://gerrit.cloudera.org:8080/#/c/11079/3/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java@109
PS3, Line 109: * Table client objects are thread-unsafe and cheap to create. The HBase docs recommend
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/11079/3/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java@238
PS3, Line 238: // This should never happen - Hive blocks creating a mismatched table and both Hive
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/11079/3/fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java@354
PS3, Line 354: * @return The estimated number of rows in the regions between the row keys (first) and
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Aug 2018 00:19:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7258: Support querying HBase tables in LocalCatalog
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11079 )
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog
......................................................................
IMPALA-7258: Support querying HBase tables in LocalCatalog
This is a straightforward porting expecting no behavior change. All of
the HBase E2E tests passes with this patch.
Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddReplaceColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
A fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java
M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
A fe/src/main/java/org/apache/impala/catalog/local/LocalHbaseTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/planner/TableSink.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
21 files changed, 924 insertions(+), 739 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/11079/2
--
To view, visit http://gerrit.cloudera.org:8080/11079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899
Gerrit-Change-Number: 11079
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>