You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/03/23 16:32:54 UTC
[GitHub] [fineract] sheminanto opened a new pull request #2176: FINERACT-1541: Pentaho accounting reports converted to table format
sheminanto opened a new pull request #2176:
URL: https://github.com/apache/fineract/pull/2176
## Description
https://issues.apache.org/jira/browse/FINERACT-1541
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] sheminanto commented on pull request #2176: FINERACT-1541: Pentaho accounting reports converted to table format
Posted by GitBox <gi...@apache.org>.
sheminanto commented on pull request #2176:
URL: https://github.com/apache/fineract/pull/2176#issuecomment-1082694266
@galovics The migration ran successfully with both mysql and posgres. So do we need to create separate changes for mysql and postgres ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2176: FINERACT-1541: Pentaho accounting reports converted to table format
Posted by GitBox <gi...@apache.org>.
galovics commented on pull request #2176:
URL: https://github.com/apache/fineract/pull/2176#issuecomment-1083318807
@sheminanto let's differentiate 2 things, the migration and the report execution. The migration is going to run successfully for sure since you're inserting some SQL strings into the report table. But when you try to execute the SQL statements you inserted into the report table - i.e. querying a report, it's going to fail.
For example the backtick (`) is a specific character only used for MySQL to escape literals. That's going to fail with PostgreSQL. You can look at the existing migrations in `0001_initial_data.xml`. There's a separate changeset for MySQL and PostgreSQL.
Also, since this didn't fail the build, I'd appreacite if you could add some integration tests for each report you created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics edited a comment on pull request #2176: FINERACT-1541: Pentaho accounting reports converted to table format
Posted by GitBox <gi...@apache.org>.
galovics edited a comment on pull request #2176:
URL: https://github.com/apache/fineract/pull/2176#issuecomment-1083318807
@sheminanto let's differentiate 2 things, the migration and the report execution. The migration is going to run successfully for sure since you're inserting some SQL strings into the report table. But when you try to execute the SQL statements you inserted into the report table - i.e. querying a report, it's going to fail.
For example the backtick (\`) is a specific character only used for MySQL to escape literals. That's going to fail with PostgreSQL. You can look at the existing migrations in `0001_initial_data.xml`. There's a separate changeset for MySQL and PostgreSQL.
Also, since this didn't fail the build, I'd appreacite if you could add some integration tests for each report you created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org