You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/07/30 21:01:24 UTC
Review Request 71203: Added check script to check for license headers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71203/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Bugs: MESOS-9360
https://issues.apache.org/jira/browse/MESOS-9360
Repository: mesos
Description
-------
This check adds a script which validates that source files have valid
license headers. This will allow us to reuse this functionality with
e.g., the pre-commit tool.
At the moment the code added here is not invoked from
`support/mesos-style.py` since it will be removed in a follow-up commit.
Diffs
-----
support/check_license.py PRE-CREATION
Diff: https://reviews.apache.org/r/71203/diff/1/
Testing
-------
* tested against files with license headers present or absent
* tested against all Python and C++ source files in the repo
Thanks,
Benjamin Bannier
Re: Review Request 71203: Added check script to check for license
headers.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71203/#review217462
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Aug. 19, 2019, 12:20 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71203/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2019, 12:20 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This check adds a script which validates that source files have valid
> license headers. This will allow us to reuse this functionality with
> e.g., the pre-commit tool.
>
> At the moment the code added here is not invoked from
> `support/mesos-style.py` since it will be removed in a follow-up commit.
>
>
> Diffs
> -----
>
> support/check-license.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71203/diff/5/
>
>
> Testing
> -------
>
> * tested against files with license headers present or absent
> * tested against all Python and C++ source files in the repo
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71203: Added check script to check for license
headers.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71203/#review217281
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On Aug. 19, 2019, 7:20 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71203/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2019, 7:20 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This check adds a script which validates that source files have valid
> license headers. This will allow us to reuse this functionality with
> e.g., the pre-commit tool.
>
> At the moment the code added here is not invoked from
> `support/mesos-style.py` since it will be removed in a follow-up commit.
>
>
> Diffs
> -----
>
> support/check-license.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71203/diff/5/
>
>
> Testing
> -------
>
> * tested against files with license headers present or absent
> * tested against all Python and C++ source files in the repo
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71203: Added check script to check for license
headers.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71203/#review217432
-----------------------------------------------------------
Ship it!
support/check-license.py
Lines 25-26 (patched)
<https://reviews.apache.org/r/71203/#comment304708>
Nifty python code :)
- Till Toenshoff
On Aug. 19, 2019, 7:20 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71203/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2019, 7:20 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This check adds a script which validates that source files have valid
> license headers. This will allow us to reuse this functionality with
> e.g., the pre-commit tool.
>
> At the moment the code added here is not invoked from
> `support/mesos-style.py` since it will be removed in a follow-up commit.
>
>
> Diffs
> -----
>
> support/check-license.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71203/diff/5/
>
>
> Testing
> -------
>
> * tested against files with license headers present or absent
> * tested against all Python and C++ source files in the repo
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71203: Added check script to check for license
headers.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71203/
-----------------------------------------------------------
(Updated Aug. 19, 2019, 9:20 a.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Rename script
Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630
Repository: mesos
Description
-------
This check adds a script which validates that source files have valid
license headers. This will allow us to reuse this functionality with
e.g., the pre-commit tool.
At the moment the code added here is not invoked from
`support/mesos-style.py` since it will be removed in a follow-up commit.
Diffs (updated)
-----
support/check-license.py PRE-CREATION
Diff: https://reviews.apache.org/r/71203/diff/5/
Changes: https://reviews.apache.org/r/71203/diff/4-5/
Testing
-------
* tested against files with license headers present or absent
* tested against all Python and C++ source files in the repo
Thanks,
Benjamin Bannier
Re: Review Request 71203: Added check script to check for license
headers.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71203/#review217265
-----------------------------------------------------------
Ship it!
Should be named `check-license.py` to be consistent with other scripts.
- James Peach
On July 30, 2019, 9:01 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71203/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 9:01 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This check adds a script which validates that source files have valid
> license headers. This will allow us to reuse this functionality with
> e.g., the pre-commit tool.
>
> At the moment the code added here is not invoked from
> `support/mesos-style.py` since it will be removed in a follow-up commit.
>
>
> Diffs
> -----
>
> support/check_license.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71203/diff/3/
>
>
> Testing
> -------
>
> * tested against files with license headers present or absent
> * tested against all Python and C++ source files in the repo
>
>
> Thanks,
>
> Benjamin Bannier
>
>