You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/04/30 16:15:35 UTC

[GitHub] [hbase] joshelser commented on a change in pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

joshelser commented on a change in pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#discussion_r418128491



##########
File path: dev-support/hbase-personality.sh
##########
@@ -146,7 +146,7 @@ function personality_modules
   fi
 
   if [[ -n "${HADOOP_PROFILE}" ]]; then
-    extra="${extra} -Phadoop-${HADOOP_PROFILE}"
+    extra="${extra} -Dhadoop.profile=${HADOOP_PROFILE}"

Review comment:
       My assumption was that we could do this when we invoke yetus and then not have to sully the personality itself.
   
   I guess there is an expectation that people can invoke yetus by hand, too. Makes me wonder if it's easier to just do it all in the personality then.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org