You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by "Roman Khachatryan (Jira)" <ji...@apache.org> on 2022/08/31 11:06:00 UTC

[jira] [Created] (FLINK-29157) Clarify the contract between CompletedCheckpointStore and SharedStateRegistry

Roman Khachatryan created FLINK-29157:
-----------------------------------------

             Summary: Clarify the contract between CompletedCheckpointStore and SharedStateRegistry
                 Key: FLINK-29157
                 URL: https://issues.apache.org/jira/browse/FLINK-29157
             Project: Flink
          Issue Type: Technical Debt
          Components: Runtime / Checkpointing
    Affects Versions: 1.15.2, 1.16.0
            Reporter: Roman Khachatryan
            Assignee: Roman Khachatryan
             Fix For: 1.16.0, 1.15.3


After FLINK-24611, CompletedCheckpointStore is required to call SharedStateRegistry.unregisterUnusedState() on checkpoint subsumption and shutdown.

Although it's not clear whether CompletedCheckpointStore is internal there are in fact external implementations (which weren't updated accordingly).

 

After FLINK-25872, CompletedCheckpointStore also must call checkpointsCleaner.cleanSubsumedCheckpoints.

 

Another issue with a custom implementation was using different java objects for state for CheckpointStore and SharedStateRegistry (after FLINK-24086). 

 

So it makes sense to:
 * clarify the contract (different in 1.15 and 1.16)
 * require using the same checkpoint objects by SharedStateRegistryFactory and CompletedCheckpointStore
 * mark the interface(s) as PublicEvolving



--
This message was sent by Atlassian Jira
(v8.20.10#820010)