You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Bertrand Dechoux (JIRA)" <ji...@apache.org> on 2012/09/12 11:29:07 UTC
[jira] [Created] (HADOOP-8791) rm "Only deletes non empty directory
and files."
Bertrand Dechoux created HADOOP-8791:
----------------------------------------
Summary: rm "Only deletes non empty directory and files."
Key: HADOOP-8791
URL: https://issues.apache.org/jira/browse/HADOOP-8791
Project: Hadoop Common
Issue Type: Bug
Components: documentation
Affects Versions: 1.0.3
Reporter: Bertrand Dechoux
The documentation (1.0.3) is describing the opposite of what rm does.
It should be "Only delete files and empty directories."
With regards to file, the size of the file should not matter, should it?
OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Bertrand Dechoux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463114#comment-13463114 ]
Bertrand Dechoux commented on HADOOP-8791:
------------------------------------------
I have to confess that I am a bit lost.
* currently (1.0.3) the rm delete only files (no directory, empty or not)
* a rmdir command has been added to the trunk(cool)
* rmr is still around in the trunk but a -r option was added to rm
What is the difference between rmr and rm -r, then? And if there is such an option, I assume that the rm command will once again delete directories? It should be carefully documented.
@Jing : You should add the -r option in the command description too for the trunk.
=> dfs -rm [-r] [-skipTrash]
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.001.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.001.patch, HADOOP-8791-trunk.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8791) rm "Only deletes non empty directory
and files."
Posted by "Jing Zhao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jing Zhao updated HADOOP-8791:
------------------------------
Attachment: HADOOP-8791-trunk.001.patch
HADOOP-8791-branch-1.001.patch
Thanks for the comments Suresh! Will create the jira for rm document in trunk.
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.001.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.001.patch, HADOOP-8791-trunk.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8791) rm "Only deletes non empty directory
and files."
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-8791:
----------------------------------------
Fix Version/s: 0.23.5
I pulled this into branch-0.23
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Fix For: 1.2.0, 3.0.0, 2.0.3-alpha, 0.23.5
>
> Attachments: HADOOP-8791-branch-1.001.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.001.patch, HADOOP-8791-trunk.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463781#comment-13463781 ]
Hudson commented on HADOOP-8791:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1177 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1177/])
HADOOP-8791. Fix rm command documentation to indicte it deletes files and not directories. Contributed by Jing Zhao. (Revision 1390109)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390109
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/file_system_shell.xml
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Fix For: 1.2.0, 3.0.0, 2.0.3-alpha
>
> Attachments: HADOOP-8791-branch-1.001.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.001.patch, HADOOP-8791-trunk.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463830#comment-13463830 ]
Hudson commented on HADOOP-8791:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1208 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1208/])
HADOOP-8791. Fix rm command documentation to indicte it deletes files and not directories. Contributed by Jing Zhao. (Revision 1390109)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390109
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/file_system_shell.xml
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Fix For: 1.2.0, 3.0.0, 2.0.3-alpha
>
> Attachments: HADOOP-8791-branch-1.001.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.001.patch, HADOOP-8791-trunk.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8791) rm "Only deletes non empty directory
and files."
Posted by "Jing Zhao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jing Zhao updated HADOOP-8791:
------------------------------
Attachment: HADOOP-8791-trunk.patch
HADOOP-8791-branch-1.patch
Updated for both branch-1 and trunk. Also mentioned "-rm -r" for the trunk patch.
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467673#comment-13467673 ]
Hudson commented on HADOOP-8791:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #392 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/392/])
svn merge -c 1390109 FIXES: HADOOP-8791. Fix rm command documentation to indicte it deletes files and not directories. Contributed by Jing Zhao. (Revision 1392437)
Result = UNSTABLE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1392437
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/file_system_shell.xml
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Fix For: 1.2.0, 3.0.0, 2.0.3-alpha, 0.23.5
>
> Attachments: HADOOP-8791-branch-1.001.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.001.patch, HADOOP-8791-trunk.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463182#comment-13463182 ]
Hudson commented on HADOOP-8791:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2832 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2832/])
HADOOP-8791. Fix rm command documentation to indicte it deletes files and not directories. Contributed by Jing Zhao. (Revision 1390109)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390109
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/file_system_shell.xml
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Fix For: 1.2.0, 3.0.0, 2.0.3-alpha
>
> Attachments: HADOOP-8791-branch-1.001.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.001.patch, HADOOP-8791-trunk.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456348#comment-13456348 ]
Hadoop QA commented on HADOOP-8791:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545268/HADOOP-8791-trunk.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that doesn't require tests.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1469//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/1469//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1469//console
This message is automatically generated.
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Bertrand Dechoux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455649#comment-13455649 ]
Bertrand Dechoux commented on HADOOP-8791:
------------------------------------------
I made the same test on the 1.0.3 version and I can confirm that directories can not be delete, being empty or not has no influence...
@Hemanth : so yes, the documentation should be updated to say only files.
Can someone check for previous versions? Is that a regression? Or a documentation that was never correct? If that's a regression, should it be corrected now that's the 1.0.3 (and I guess the 1.0) behaviour?
I also tested on 1.0.3 whether size of files has an impact but it doesn't.
Second question : if the observed behaviour is the 'correct' one, it would really beg for a 'rmdir' equivalent command for HDFS.
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Andy Isaacson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456116#comment-13456116 ]
Andy Isaacson commented on HADOOP-8791:
---------------------------------------
bq. we could add a new rmdir in FsShell
There's already {{hdfs dfs -rmdir}} in trunk. It behaves like Unix rmdir: it only deletes empty directories, failing with "Directory is not empty" if there are files or subdirectories.
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456329#comment-13456329 ]
Harsh J commented on HADOOP-8791:
---------------------------------
Thanks Andy, missed that addition. We should just fix the docs then, on this issue.
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Jing Zhao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463120#comment-13463120 ]
Jing Zhao commented on HADOOP-8791:
-----------------------------------
For trunk, it seems the rm can actually delete both files and directories (with -[rR]). The rm command also has new -f option. We should address all these new options in the document for trunk, and I will do that in HADOOP-8841.
For branch-1, the rm only deletes files, so we can change the document based on the above discussion.
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.001.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.001.patch, HADOOP-8791-trunk.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463225#comment-13463225 ]
Hudson commented on HADOOP-8791:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2791 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2791/])
HADOOP-8791. Fix rm command documentation to indicte it deletes files and not directories. Contributed by Jing Zhao. (Revision 1390109)
Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390109
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/file_system_shell.xml
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Fix For: 1.2.0, 3.0.0, 2.0.3-alpha
>
> Attachments: HADOOP-8791-branch-1.001.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.001.patch, HADOOP-8791-trunk.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454264#comment-13454264 ]
Hadoop QA commented on HADOOP-8791:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12544860/HADOOP-8791-trunk.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that doesn't require tests.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1443//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1443//console
This message is automatically generated.
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463036#comment-13463036 ]
Hadoop QA commented on HADOOP-8791:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12546547/HADOOP-8791-trunk.001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1518//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1518//console
This message is automatically generated.
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.001.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.001.patch, HADOOP-8791-trunk.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers reassigned HADOOP-8791:
--------------------------------------
Assignee: Jing Zhao
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454082#comment-13454082 ]
Harsh J commented on HADOOP-8791:
---------------------------------
The original doc under question is:
{quote}
Delete files specified as args. Only deletes non empty directory and files.
{quote}
While there's actually supposed to be a separation, i.e. "non empty directories" AND "files" in reading this, you're right that this is ambiguous.
Wanna send across a patch for both branch-1 and trunk Bertrand? :)
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3
> Reporter: Bertrand Dechoux
> Labels: documentation
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462783#comment-13462783 ]
Suresh Srinivas commented on HADOOP-8791:
-----------------------------------------
Patch looks good. Minor comment - under rmr we should mention it recursively deletes the directory and any content under it.
@Jing can you please create another jira for the following: In trunk for command rm, the flags -[rR] and -f are not documented.
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455656#comment-13455656 ]
Hemanth Yamijala commented on HADOOP-8791:
------------------------------------------
The behaviour is the same with 1.0.2 as well.
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463164#comment-13463164 ]
Suresh Srinivas commented on HADOOP-8791:
-----------------------------------------
+1 for the patch.
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.001.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.001.patch, HADOOP-8791-trunk.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455586#comment-13455586 ]
Hemanth Yamijala commented on HADOOP-8791:
------------------------------------------
Also, I think the examples in the same documentation section might need update to reflect that empty directories can't be removed.
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8791) rm "Only deletes non empty directory
and files."
Posted by "Jing Zhao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jing Zhao updated HADOOP-8791:
------------------------------
Affects Version/s: 3.0.0
Status: Patch Available (was: Open)
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455575#comment-13455575 ]
Hemanth Yamijala commented on HADOOP-8791:
------------------------------------------
It looks like rm cannot even delete empty directories. Tried this on both 1.0.3 and trunk. We should modify the documentation to only specify that it deletes files, right ?
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8791) rm "Only deletes non empty directory
and files."
Posted by "Jing Zhao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jing Zhao updated HADOOP-8791:
------------------------------
Attachment: HADOOP-8791-trunk.patch
HADOOP-8791-branch-1.patch
So I did the two patches for branch-1 and trunk for Bertrand. Thanks for the finding Bertrand!
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3
> Reporter: Bertrand Dechoux
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455966#comment-13455966 ]
Harsh J commented on HADOOP-8791:
---------------------------------
That doc is pretty old so we may have regressed long ago as well. I suppose we could add a new rmdir in FsShell, as a client-side tool, instead of having rm delete directories - to stick to usual convention.
I'd like Daryn's thoughts for a new command though.
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Attachments: HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8791) rm "Only deletes non empty directory
and files."
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8791:
------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.3-alpha
3.0.0
1.2.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I committed the patch. Thank you Jing for the patch. Thank you Bertrand for reporting the issue.
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Fix For: 1.2.0, 3.0.0, 2.0.3-alpha
>
> Attachments: HADOOP-8791-branch-1.001.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.001.patch, HADOOP-8791-trunk.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463178#comment-13463178 ]
Hudson commented on HADOOP-8791:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2769 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2769/])
HADOOP-8791. Fix rm command documentation to indicte it deletes files and not directories. Contributed by Jing Zhao. (Revision 1390109)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390109
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/file_system_shell.xml
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3, 3.0.0
> Reporter: Bertrand Dechoux
> Assignee: Jing Zhao
> Labels: documentation
> Fix For: 1.2.0, 3.0.0, 2.0.3-alpha
>
> Attachments: HADOOP-8791-branch-1.001.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-branch-1.patch, HADOOP-8791-trunk.001.patch, HADOOP-8791-trunk.patch, HADOOP-8791-trunk.patch
>
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8791) rm "Only deletes non empty
directory and files."
Posted by "Bertrand Dechoux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454109#comment-13454109 ]
Bertrand Dechoux commented on HADOOP-8791:
------------------------------------------
And "non empty directories" is actually "empty directories". This one is not ambiguous but wrong.
I might send a patch but that won't be soon. I might have a go at it around 22-23th but no promise.
> rm "Only deletes non empty directory and files."
> ------------------------------------------------
>
> Key: HADOOP-8791
> URL: https://issues.apache.org/jira/browse/HADOOP-8791
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 1.0.3
> Reporter: Bertrand Dechoux
> Labels: documentation
>
> The documentation (1.0.3) is describing the opposite of what rm does.
> It should be "Only delete files and empty directories."
> With regards to file, the size of the file should not matter, should it?
> OR I am totally misunderstanding the semantic of this command and I am not the only one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira