[jira] [Commented] (HBASE-5923) Cleanup checkAndXXX logic

["Lars Hofhansl (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287911#comment-13287911 ] 

Lars Hofhansl commented on HBASE-5923:
--------------------------------------

That works. The other problem is o.a.h.h.Filter.WritableByteArrayComparable.
I thought I could move this to o.a.h.h.BaseWritableByteArrayComparable and have o.a.h.h.Filter.WritableByteArrayComparable be a no-op subclass, but that would change the wire protocol :(

Initially I thought one could just always BinaryComparator, but especially for LESS/GREATER type operations it is important to be able to control the sort order (for example for Unicode).

It seems I'm stumped. Either o.a.h.h.Filter.WritableByteArrayComparable has to leak up into HTableInterface, or the wire protocol changes.

                
> Cleanup checkAndXXX logic
> -------------------------
>
>                 Key: HBASE-5923
>                 URL: https://issues.apache.org/jira/browse/HBASE-5923
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, regionserver
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Minor
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: 5923-0.94.txt, 5923-trunk.txt
>
>
> 1. the checkAnd{Put|Delete} method that takes a CompareOP is not exposed via HTable[Interface].
> 2. there is unnecessary duplicate code in the check{Put|Delete} code in HRegionServer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira