[jira] [Work logged] (HIVE-25812) GetResultSchema service called in ERROR state

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-25812?focusedWorklogId=696963&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-696963 ]

ASF GitHub Bot logged work on HIVE-25812:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Dec/21 00:08
            Start Date: 16/Dec/21 00:08
    Worklog Time Spent: 10m 
      Work Description: scarlin-cloudera opened a new pull request #2883:
URL: https://github.com/apache/hive/pull/2883


   After the "Execute" call is made from an HS2 client, the
   "GetResultsMetaData" is called, followed by the "Fetch" call.
   
   If the "Execute" sets the error state to "ERROR" before the
   GetResultsMetaData has been called, an exception is thrown
   since it only expects the state to be RUNNING or FINISHED.
   
   This commit allows the status to be ERROR when GetResultsMetaData
   is called.
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   Allow the server to be in ERROR state on the GetResultsMetaData thrift call
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   The ERROR status can be set by the background executor thread before the
   GetResultsMetaData is called, so it is a valid state.
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   This shouldn't cause any harm since an exception was being thrown. The error message will be a bit more pleasant though from an end user perspective.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 696963)
    Remaining Estimate: 0h
            Time Spent: 10m

> GetResultSchema service called in ERROR state
> ---------------------------------------------
>
>                 Key: HIVE-25812
>                 URL: https://issues.apache.org/jira/browse/HIVE-25812
>             Project: Hive
>          Issue Type: Improvement
>          Components: CLI
>            Reporter: Steve Carlin
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> After the "Execute" call is made from an HS2 client, the "GetResultsMetaData" is called, followed by the "Fetch" call.
> If the "Execute" sets the error state to "ERROR" before the GetResultsMetaData has been called, an exception is thrown since it only expects the state to be RUNNING or FINISHED.
> The code affecting it is SQLOperation:
>  
> {code:java}
>   @Override
>   public TableSchema getResultSetSchema() throws HiveSQLException {
>     // Since compilation is always a blocking RPC call, and schema is ready after compilation,
>     // we can return when are in the RUNNING state.
>     assertState(Arrays.asList(OperationState.RUNNING, OperationState.FINISHED));
>     if (resultSchema == null) {
>       resultSchema = new TableSchema(driver.getSchema());
>     }   
>     return resultSchema;
>   }
> {code}
>  
> Adding ERROR to "assertState" should fix the problem.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)