You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/08 00:23:19 UTC

[GitHub] [tvm] zxybazh opened a new pull request, #10935: [MetaSchedule][Minor] Fix Integer Overflow in Tuning Statistics

zxybazh opened a new pull request, #10935:
URL: https://github.com/apache/tvm/pull/10935

   This PR fixes the integer overflow when the flop count of a given workload is larger than `MAX_INT` during tuning statistics printing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] zxybazh commented on pull request #10935: [MetaSchedule][Minor] Fix Integer Overflow in Tuning Statistics

Posted by GitBox <gi...@apache.org>.
zxybazh commented on PR #10935:
URL: https://github.com/apache/tvm/pull/10935#issuecomment-1092352347

   Hi Masa, this PR fixes exactly the same issue in your output. I verified locally that it can fix the table. The cause of the error is introduced in gradient based task scheduler where we print the tuning statistics table by static casting flop number in tuning records to int, which overflows.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #10935: [MetaSchedule][Minor] Fix Integer Overflow in Tuning Statistics

Posted by GitBox <gi...@apache.org>.
masahi commented on PR #10935:
URL: https://github.com/apache/tvm/pull/10935#issuecomment-1092360136

   I tried this change but still got an invalid FLOP. Note that the sign is flipped this time
   
   ```
   [10:43:53] /home/masa/projects/dev/tvm/src/meta_schedule/task_scheduler/gradient_based.cc:111: 
    ID |                        Name |       FLOP | Weight | Speed (GFLOPS) | Latency (us) | Weighted Latency (us) | Trials | Terminated 
   --------------------------------------------------------------------------------------------------------------------------------------
     0 | fused_nn_contrib_dense_pack | 2147483648 |      1 |            N/A |          N/A |                   N/A |      0 |            
   --------------------------------------------------------------------------------------------------------------------------------------
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] zxybazh commented on pull request #10935: [MetaSchedule][Minor] Fix Integer Overflow in Tuning Statistics

Posted by GitBox <gi...@apache.org>.
zxybazh commented on PR #10935:
URL: https://github.com/apache/tvm/pull/10935#issuecomment-1274315777

   Seems so.
   
   On Thu, Apr 7, 2022 at 6:45 PM Masahiro Masuda ***@***.***>
   wrote:
   
   > Or maybe 2147483648 is the correct FLOP count for my workload? Need to
   > check...
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/tvm/pull/10935#issuecomment-1092360573>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAYOAZVJLEMEDWBCM76TOH3VD6FTTANCNFSM5S267L6Q>
   > .
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #10935: [MetaSchedule][Minor] Fix Integer Overflow in Tuning Statistics

Posted by GitBox <gi...@apache.org>.
masahi commented on PR #10935:
URL: https://github.com/apache/tvm/pull/10935#issuecomment-1092349652

   Actually I'm getting something like
   
   ```
    ID |                  Name |        FLOP | Weight | Speed (GFLOPS) | Latency (us) | Weighted Latency (us) | Trials | Terminated 
   ---------------------------------------------------------------------------------------------------------------------------------
     0 | fused_nn_batch_matmul | -2147483648 |      1 |            N/A |          N/A |                   N/A |      0 |            
   ---------------------------------------------------------------------------------------------------------------------------------
   ```
   When tuning int8 workloads. Does this PR fix it? The flops count from `echo_statistics.cc` is correct, so I wondered why I'm getting this funny FLOP.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #10935: [MetaSchedule][Minor] Fix Integer Overflow in Tuning Statistics

Posted by GitBox <gi...@apache.org>.
masahi merged PR #10935:
URL: https://github.com/apache/tvm/pull/10935


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] zxybazh commented on pull request #10935: [MetaSchedule][Minor] Fix Integer Overflow in Tuning Statistics

Posted by GitBox <gi...@apache.org>.
zxybazh commented on PR #10935:
URL: https://github.com/apache/tvm/pull/10935#issuecomment-1092375983

   Then it is 2*(2^10)^3=2^31, サプライズ!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #10935: [MetaSchedule][Minor] Fix Integer Overflow in Tuning Statistics

Posted by GitBox <gi...@apache.org>.
masahi commented on PR #10935:
URL: https://github.com/apache/tvm/pull/10935#issuecomment-1092360573

   Or maybe 2147483648 is the correct FLOP count for my workload? Need to check...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org