[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #180: Add SnapshotUpdate interface with set method.

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #180: Add SnapshotUpdate interface with set method.
URL: https://github.com/apache/incubator-iceberg/pull/180#discussion_r282939791
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
 ##########
 @@ -55,8 +55,8 @@
 import static org.apache.iceberg.TableProperties.MANIFEST_TARGET_SIZE_BYTES;
 import static org.apache.iceberg.TableProperties.MANIFEST_TARGET_SIZE_BYTES_DEFAULT;
 
-abstract class MergingSnapshotUpdate extends SnapshotUpdate {
-  private static final Logger LOG = LoggerFactory.getLogger(MergingSnapshotUpdate.class);
+abstract class MergingSnapshotProducer<ThisT> extends SnapshotProducer<ThisT> {
 
 Review comment:
   THIS is not allowed by baseline linting. I'm not sure how the other made it through... @mccheah, is baseline applied the same way to the API module?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org