You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/13 09:53:59 UTC

[GitHub] [airflow] FloChehab opened a new pull request #13649: Fix pod launcher role permissions to list events in chart

FloChehab opened a new pull request #13649:
URL: https://github.com/apache/airflow/pull/13649


   Hello, here is a small fix on the chart to prevent an airflow exception due to https://github.com/apache/airflow/blob/master/airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py#L490.
   
   I think adding a test for this is bit hard, but I am opened to suggestion.
   
   More info:
   
   When using the KubernetesPodOperator with
   log_events_on_failure=True, and the pod exits,
   the executor needs to access the events in the namespace.
   
   Before this resulted in an exception when using the chart
   as this it was not permitted by the pod-launcher role.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil merged pull request #13649: Fix pod launcher role permissions to list events in chart

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13649:
URL: https://github.com/apache/airflow/pull/13649


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] FloChehab commented on pull request #13649: Fix pod launcher role permissions to list events in chart

Posted by GitBox <gi...@apache.org>.
FloChehab commented on pull request #13649:
URL: https://github.com/apache/airflow/pull/13649#issuecomment-775402092


   Hello @kaxil, maybe you have time to review this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org