You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2016/04/05 20:05:27 UTC
Review Request 45759: GEODE-1162: convert all CLI command DUnit tests
to JUnit 4
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45759/
-----------------------------------------------------------
Review request for geode, Jens Deppe and Jinmei Liao.
Bugs: GEODE-1161 and GEODE-1162
https://issues.apache.org/jira/browse/GEODE-1161
https://issues.apache.org/jira/browse/GEODE-1162
Repository: geode
Description
-------
GEODE-1162: convert all CLI command DUnit tests to JUnit 4
* GEODE-1161: cleanup VM and AsyncInvocation in DUnit
* define FlakyTest JUnit category
* define SecurityTest JUnit category and apply to all security tests (probably missed a few)
* create category test to discover JUnit behavior
Diffs
-----
geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java 2344155
geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java edd056b
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/AbstractCommandsSupportJUnitTest.java 8d9971e
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 7d8dc55
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java 7cfb693
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java 10b37c1
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java b70b9fa
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 566977c
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsJUnitTest.java 4b9f4c6
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/FunctionCommandsDUnitTest.java 8451916
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 7151ffd
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GetCommandOnRegionWithCacheLoaderDuringCacheMissDUnitTest.java 6704979
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HTTPServiceSSLSupportJUnitTest.java 49f405c
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 431c6b3
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsJUnitTest.java bf77aba
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeDiskStoreCommandsDUnitTest.java 744824f
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java 2d11491
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListIndexCommandDUnitTest.java caa33fb
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MemberCommandsDUnitTest.java 44cead8
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java d44a479
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java b9178b6
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart2DUnitTest.java 678af5a
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java 361a8d1
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart4DUnitTest.java 360ba08
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommandsDUnitTest.java c4d1f93
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java 5805853
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java ee6fcac
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowDeadlockDUnitTest.java 6bf05b3
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowMetricsDUnitTest.java 90d0eed
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowStackTraceDUnitTest.java 9a72d36
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/UserCommandsDUnitTest.java 97a9305
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationDUnitTest.java ea83a66
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationPart2DUnitTest.java b633865
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationTestCase.java 191ea3e
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationDUnitTest.java eeb2c39
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTestCase.java 088dec4
geode-core/src/test/java/com/gemstone/gemfire/security/ClientMultiUserAuthzDUnitTest.java 441d52c
geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientAuthorizationDUnitTest.java 904a53c
geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientPostAuthorizationDUnitTest.java 222ea00
geode-core/src/test/java/com/gemstone/gemfire/security/GemFireSecurityExceptionTest.java 0c048d3
geode-core/src/test/java/com/gemstone/gemfire/security/NotAuthorizedExceptionTest.java c5e0ba5
geode-core/src/test/java/com/gemstone/gemfire/security/P2PAuthenticationDUnitTest.java 1db599f
geode-core/src/test/java/com/gemstone/gemfire/security/SecurityTestUtils.java 663a17d
geode-core/src/test/java/com/gemstone/gemfire/security/generator/AuthzCredentialGenerator.java f39fc84
geode-core/src/test/java/com/gemstone/gemfire/security/generator/CredentialGenerator.java aee7ebb
geode-core/src/test/java/com/gemstone/gemfire/security/generator/DummyCredentialGenerator.java b709dbc
geode-core/src/test/java/com/gemstone/gemfire/security/generator/LdapUserCredentialGenerator.java bbd9528
geode-core/src/test/java/com/gemstone/gemfire/security/generator/PKCSCredentialGenerator.java 6d33493
geode-core/src/test/java/com/gemstone/gemfire/security/generator/SSLCredentialGenerator.java ff23f78
geode-core/src/test/java/com/gemstone/gemfire/security/generator/UserPasswordWithExtraPropsAuthInit.java b29f16b
geode-core/src/test/java/com/gemstone/gemfire/security/generator/XmlAuthzCredentialGenerator.java 5d07004
geode-core/src/test/java/com/gemstone/gemfire/security/templates/DummyAuthorization.java a76a46f
geode-core/src/test/java/com/gemstone/gemfire/security/templates/LdapUserAuthenticator.java fd2286e
geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSAuthInit.java 0b38a7b
geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSAuthenticator.java 971cf60
geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSPrincipalTest.java e0bc1e4
geode-core/src/test/java/com/gemstone/gemfire/security/templates/UserPasswordAuthInit.java 34161ac
geode-core/src/test/java/com/gemstone/gemfire/security/templates/UsernamePrincipalTest.java e762d06
geode-core/src/test/java/com/gemstone/gemfire/security/templates/XmlAuthorization.java b8f2e50
geode-core/src/test/java/com/gemstone/gemfire/security/templates/XmlErrorHandler.java 19d10c6
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/AsyncInvocation.java a612f87
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestCase.java c0245f2
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestUtils.java c1850de
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/ThreadUtils.java fe8f260
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/VM.java 962978f
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/Wait.java b73a25c
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/cache/internal/JUnit4CacheTestCase.java b5bd5f7
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit3DistributedTestCase.java f453e7e
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit4DistributedTestCase.java d5b5b6f
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3BasicDUnitTest.java 5130b5c
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3GetDefaultDiskStoreNameDUnitTest.java e89f66b
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3GetTestMethodNameDUnitTest.java c77843d
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3VMDUnitTest.java ac2ed7e
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4BasicDUnitTest.java 5cac3ba
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4GetDefaultDiskStoreNameDUnitTest.java 7f99bc1
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4GetTestMethodNameDUnitTest.java 93b2e86
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4VMDUnitTest.java c9d9d3c
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/DistributedRestoreSystemProperties.java 7f95fad
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/RemoteInvoker.java 98dbc2f
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ChildVM.java 06c3196
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java 216971a
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/RemoteDUnitVM.java 81c895e
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/RemoteDUnitVMIF.java 849e2f2
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/BasicDUnitTest.java b10f610
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4BasicDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4GetDefaultDiskStoreNameDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4GetTestMethodNameDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4OverridingGetPropertiesDisconnectsAllDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4VMDUnitTest.java PRE-CREATION
geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java f1afdaf
geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DurableClientCommandsDUnitTest.java 0a1f433
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTwoDUnitTest.java e2950c2
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java 0e8e57f
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientCQPostAuthorizationDUnitTest.java dfa89f9
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java ce03ac6
geode-cq/src/test/java/com/gemstone/gemfire/security/MultiUserAPIDUnitTest.java 9e04f5f
geode-cq/src/test/java/com/gemstone/gemfire/security/MultiUserDurableCQAuthzDUnitTest.java 632a997
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/FlakyTest.java PRE-CREATION
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/SecurityTest.java PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryOne.java PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryTest.java PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryTwo.java PRE-CREATION
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WANCommandTestBase.java 9bfce05
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandCreateGatewayReceiverDUnitTest.java 1122059
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandCreateGatewaySenderDUnitTest.java 2c99ad3
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewayReceiverStartDUnitTest.java 6f26e3b
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewayReceiverStopDUnitTest.java 82ca3ba
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewaySenderStartDUnitTest.java a10a926
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewaySenderStopDUnitTest.java f0e51bf
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandListDUnitTest.java 8880348
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandPauseResumeDUnitTest.java 360f2ab
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandStatusDUnitTest.java 12d81d7
geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java 43caf90
Diff: https://reviews.apache.org/r/45759/diff/
Testing
-------
precheckin
Thanks,
Kirk Lund
Re: Review Request 45759: GEODE-1162: convert all CLI command DUnit
tests to JUnit 4
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45759/#review127167
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On April 5, 2016, 6:05 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45759/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 6:05 p.m.)
>
>
> Review request for geode, Jens Deppe and Jinmei Liao.
>
>
> Bugs: GEODE-1161 and GEODE-1162
> https://issues.apache.org/jira/browse/GEODE-1161
> https://issues.apache.org/jira/browse/GEODE-1162
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1162: convert all CLI command DUnit tests to JUnit 4
>
> * GEODE-1161: cleanup VM and AsyncInvocation in DUnit
> * define FlakyTest JUnit category
> * define SecurityTest JUnit category and apply to all security tests (probably missed a few)
> * create category test to discover JUnit behavior
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java 2344155
> geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java edd056b
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/AbstractCommandsSupportJUnitTest.java 8d9971e
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 7d8dc55
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java 7cfb693
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java 10b37c1
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java b70b9fa
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 566977c
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsJUnitTest.java 4b9f4c6
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/FunctionCommandsDUnitTest.java 8451916
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 7151ffd
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GetCommandOnRegionWithCacheLoaderDuringCacheMissDUnitTest.java 6704979
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HTTPServiceSSLSupportJUnitTest.java 49f405c
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 431c6b3
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsJUnitTest.java bf77aba
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeDiskStoreCommandsDUnitTest.java 744824f
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java 2d11491
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListIndexCommandDUnitTest.java caa33fb
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MemberCommandsDUnitTest.java 44cead8
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java d44a479
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java b9178b6
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart2DUnitTest.java 678af5a
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java 361a8d1
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart4DUnitTest.java 360ba08
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommandsDUnitTest.java c4d1f93
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java 5805853
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java ee6fcac
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowDeadlockDUnitTest.java 6bf05b3
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowMetricsDUnitTest.java 90d0eed
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowStackTraceDUnitTest.java 9a72d36
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/UserCommandsDUnitTest.java 97a9305
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationDUnitTest.java ea83a66
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationPart2DUnitTest.java b633865
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationTestCase.java 191ea3e
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationDUnitTest.java eeb2c39
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTestCase.java 088dec4
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientMultiUserAuthzDUnitTest.java 441d52c
> geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientAuthorizationDUnitTest.java 904a53c
> geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientPostAuthorizationDUnitTest.java 222ea00
> geode-core/src/test/java/com/gemstone/gemfire/security/GemFireSecurityExceptionTest.java 0c048d3
> geode-core/src/test/java/com/gemstone/gemfire/security/NotAuthorizedExceptionTest.java c5e0ba5
> geode-core/src/test/java/com/gemstone/gemfire/security/P2PAuthenticationDUnitTest.java 1db599f
> geode-core/src/test/java/com/gemstone/gemfire/security/SecurityTestUtils.java 663a17d
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/AuthzCredentialGenerator.java f39fc84
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/CredentialGenerator.java aee7ebb
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/DummyCredentialGenerator.java b709dbc
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/LdapUserCredentialGenerator.java bbd9528
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/PKCSCredentialGenerator.java 6d33493
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/SSLCredentialGenerator.java ff23f78
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/UserPasswordWithExtraPropsAuthInit.java b29f16b
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/XmlAuthzCredentialGenerator.java 5d07004
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/DummyAuthorization.java a76a46f
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/LdapUserAuthenticator.java fd2286e
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSAuthInit.java 0b38a7b
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSAuthenticator.java 971cf60
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSPrincipalTest.java e0bc1e4
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/UserPasswordAuthInit.java 34161ac
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/UsernamePrincipalTest.java e762d06
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/XmlAuthorization.java b8f2e50
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/XmlErrorHandler.java 19d10c6
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/AsyncInvocation.java a612f87
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestCase.java c0245f2
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestUtils.java c1850de
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/ThreadUtils.java fe8f260
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/VM.java 962978f
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/Wait.java b73a25c
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/cache/internal/JUnit4CacheTestCase.java b5bd5f7
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit3DistributedTestCase.java f453e7e
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit4DistributedTestCase.java d5b5b6f
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3BasicDUnitTest.java 5130b5c
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3GetDefaultDiskStoreNameDUnitTest.java e89f66b
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3GetTestMethodNameDUnitTest.java c77843d
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3VMDUnitTest.java ac2ed7e
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4BasicDUnitTest.java 5cac3ba
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4GetDefaultDiskStoreNameDUnitTest.java 7f99bc1
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4GetTestMethodNameDUnitTest.java 93b2e86
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4VMDUnitTest.java c9d9d3c
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/DistributedRestoreSystemProperties.java 7f95fad
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/RemoteInvoker.java 98dbc2f
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ChildVM.java 06c3196
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java 216971a
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/RemoteDUnitVM.java 81c895e
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/RemoteDUnitVMIF.java 849e2f2
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/BasicDUnitTest.java b10f610
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4BasicDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4GetDefaultDiskStoreNameDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4GetTestMethodNameDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4OverridingGetPropertiesDisconnectsAllDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4VMDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java f1afdaf
> geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DurableClientCommandsDUnitTest.java 0a1f433
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTwoDUnitTest.java e2950c2
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java 0e8e57f
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientCQPostAuthorizationDUnitTest.java dfa89f9
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java ce03ac6
> geode-cq/src/test/java/com/gemstone/gemfire/security/MultiUserAPIDUnitTest.java 9e04f5f
> geode-cq/src/test/java/com/gemstone/gemfire/security/MultiUserDurableCQAuthzDUnitTest.java 632a997
> geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/FlakyTest.java PRE-CREATION
> geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/SecurityTest.java PRE-CREATION
> geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryOne.java PRE-CREATION
> geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryTest.java PRE-CREATION
> geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryTwo.java PRE-CREATION
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WANCommandTestBase.java 9bfce05
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandCreateGatewayReceiverDUnitTest.java 1122059
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandCreateGatewaySenderDUnitTest.java 2c99ad3
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewayReceiverStartDUnitTest.java 6f26e3b
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewayReceiverStopDUnitTest.java 82ca3ba
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewaySenderStartDUnitTest.java a10a926
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewaySenderStopDUnitTest.java f0e51bf
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandListDUnitTest.java 8880348
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandPauseResumeDUnitTest.java 360f2ab
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandStatusDUnitTest.java 12d81d7
> geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java 43caf90
>
> Diff: https://reviews.apache.org/r/45759/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 45759: GEODE-1162: convert all CLI command DUnit
tests to JUnit 4
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45759/#review127201
-----------------------------------------------------------
Ship it!
Ship It!
- Jens Deppe
On April 5, 2016, 7:49 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45759/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 7:49 p.m.)
>
>
> Review request for geode, Jens Deppe and Jinmei Liao.
>
>
> Bugs: GEODE-1161 and GEODE-1162
> https://issues.apache.org/jira/browse/GEODE-1161
> https://issues.apache.org/jira/browse/GEODE-1162
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1162: convert all CLI command DUnit tests to JUnit 4
>
> * GEODE-1161: cleanup VM and AsyncInvocation in DUnit
> * define FlakyTest JUnit category
> * define SecurityTest JUnit category and apply to all security tests (probably missed a few)
> * create category test to discover JUnit behavior
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java 2344155
> geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java edd056b
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/AbstractCommandsSupportJUnitTest.java 8d9971e
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 7d8dc55
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java 7cfb693
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java 10b37c1
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java b70b9fa
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 566977c
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsJUnitTest.java 4b9f4c6
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/FunctionCommandsDUnitTest.java 8451916
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 7151ffd
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GetCommandOnRegionWithCacheLoaderDuringCacheMissDUnitTest.java 6704979
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HTTPServiceSSLSupportJUnitTest.java 49f405c
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 431c6b3
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsJUnitTest.java bf77aba
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeDiskStoreCommandsDUnitTest.java 744824f
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java 2d11491
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListIndexCommandDUnitTest.java caa33fb
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MemberCommandsDUnitTest.java 44cead8
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java d44a479
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java b9178b6
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart2DUnitTest.java 678af5a
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java 361a8d1
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart4DUnitTest.java 360ba08
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommandsDUnitTest.java c4d1f93
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java 5805853
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java ee6fcac
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowDeadlockDUnitTest.java 6bf05b3
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowMetricsDUnitTest.java 90d0eed
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowStackTraceDUnitTest.java 9a72d36
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/UserCommandsDUnitTest.java 97a9305
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationDUnitTest.java ea83a66
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationPart2DUnitTest.java b633865
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationTestCase.java 191ea3e
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationDUnitTest.java eeb2c39
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTestCase.java 088dec4
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientMultiUserAuthzDUnitTest.java 441d52c
> geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientAuthorizationDUnitTest.java 904a53c
> geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientPostAuthorizationDUnitTest.java 222ea00
> geode-core/src/test/java/com/gemstone/gemfire/security/GemFireSecurityExceptionTest.java 0c048d3
> geode-core/src/test/java/com/gemstone/gemfire/security/NotAuthorizedExceptionTest.java c5e0ba5
> geode-core/src/test/java/com/gemstone/gemfire/security/P2PAuthenticationDUnitTest.java 1db599f
> geode-core/src/test/java/com/gemstone/gemfire/security/SecurityTestUtils.java 663a17d
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/AuthzCredentialGenerator.java f39fc84
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/CredentialGenerator.java aee7ebb
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/DummyCredentialGenerator.java b709dbc
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/LdapUserCredentialGenerator.java bbd9528
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/PKCSCredentialGenerator.java 6d33493
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/SSLCredentialGenerator.java ff23f78
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/UserPasswordWithExtraPropsAuthInit.java b29f16b
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/XmlAuthzCredentialGenerator.java 5d07004
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/DummyAuthorization.java a76a46f
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/LdapUserAuthenticator.java fd2286e
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSAuthInit.java 0b38a7b
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSAuthenticator.java 971cf60
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSPrincipalTest.java e0bc1e4
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/UserPasswordAuthInit.java 34161ac
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/UsernamePrincipalTest.java e762d06
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/XmlAuthorization.java b8f2e50
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/XmlErrorHandler.java 19d10c6
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/AsyncInvocation.java a612f87
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestCase.java c0245f2
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestUtils.java c1850de
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/ThreadUtils.java fe8f260
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/VM.java 962978f
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/Wait.java b73a25c
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/cache/internal/JUnit4CacheTestCase.java b5bd5f7
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit3DistributedTestCase.java f453e7e
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit4DistributedTestCase.java d5b5b6f
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3BasicDUnitTest.java 5130b5c
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3GetDefaultDiskStoreNameDUnitTest.java e89f66b
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3GetTestMethodNameDUnitTest.java c77843d
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3VMDUnitTest.java ac2ed7e
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4BasicDUnitTest.java 5cac3ba
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4GetDefaultDiskStoreNameDUnitTest.java 7f99bc1
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4GetTestMethodNameDUnitTest.java 93b2e86
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4VMDUnitTest.java c9d9d3c
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/DistributedRestoreSystemProperties.java 7f95fad
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/RemoteInvoker.java 98dbc2f
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ChildVM.java 06c3196
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java 216971a
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/RemoteDUnitVM.java 81c895e
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/RemoteDUnitVMIF.java 849e2f2
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/BasicDUnitTest.java b10f610
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4BasicDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4GetDefaultDiskStoreNameDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4GetTestMethodNameDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4OverridingGetPropertiesDisconnectsAllDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4VMDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java f1afdaf
> geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DurableClientCommandsDUnitTest.java 0a1f433
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTwoDUnitTest.java e2950c2
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java 0e8e57f
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientCQPostAuthorizationDUnitTest.java dfa89f9
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java ce03ac6
> geode-cq/src/test/java/com/gemstone/gemfire/security/MultiUserAPIDUnitTest.java 9e04f5f
> geode-cq/src/test/java/com/gemstone/gemfire/security/MultiUserDurableCQAuthzDUnitTest.java 632a997
> geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/FlakyTest.java PRE-CREATION
> geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/SecurityTest.java PRE-CREATION
> geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryOne.java PRE-CREATION
> geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryTest.java PRE-CREATION
> geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryTwo.java PRE-CREATION
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WANCommandTestBase.java 9bfce05
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandCreateGatewayReceiverDUnitTest.java 1122059
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandCreateGatewaySenderDUnitTest.java 2c99ad3
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewayReceiverStartDUnitTest.java 6f26e3b
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewayReceiverStopDUnitTest.java 82ca3ba
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewaySenderStartDUnitTest.java a10a926
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewaySenderStopDUnitTest.java f0e51bf
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandListDUnitTest.java 8880348
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandPauseResumeDUnitTest.java 360f2ab
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandStatusDUnitTest.java 12d81d7
> geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java 43caf90
>
> Diff: https://reviews.apache.org/r/45759/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 45759: GEODE-1162: convert all CLI command DUnit
tests to JUnit 4
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45759/#review127271
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On April 5, 2016, 7:49 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45759/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 7:49 p.m.)
>
>
> Review request for geode, Jens Deppe and Jinmei Liao.
>
>
> Bugs: GEODE-1161 and GEODE-1162
> https://issues.apache.org/jira/browse/GEODE-1161
> https://issues.apache.org/jira/browse/GEODE-1162
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1162: convert all CLI command DUnit tests to JUnit 4
>
> * GEODE-1161: cleanup VM and AsyncInvocation in DUnit
> * define FlakyTest JUnit category
> * define SecurityTest JUnit category and apply to all security tests (probably missed a few)
> * create category test to discover JUnit behavior
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java 2344155
> geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java edd056b
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/AbstractCommandsSupportJUnitTest.java 8d9971e
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 7d8dc55
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java 7cfb693
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java 10b37c1
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java b70b9fa
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 566977c
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsJUnitTest.java 4b9f4c6
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/FunctionCommandsDUnitTest.java 8451916
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 7151ffd
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GetCommandOnRegionWithCacheLoaderDuringCacheMissDUnitTest.java 6704979
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HTTPServiceSSLSupportJUnitTest.java 49f405c
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 431c6b3
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsJUnitTest.java bf77aba
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeDiskStoreCommandsDUnitTest.java 744824f
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java 2d11491
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListIndexCommandDUnitTest.java caa33fb
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MemberCommandsDUnitTest.java 44cead8
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java d44a479
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java b9178b6
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart2DUnitTest.java 678af5a
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java 361a8d1
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart4DUnitTest.java 360ba08
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommandsDUnitTest.java c4d1f93
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java 5805853
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java ee6fcac
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowDeadlockDUnitTest.java 6bf05b3
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowMetricsDUnitTest.java 90d0eed
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowStackTraceDUnitTest.java 9a72d36
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/UserCommandsDUnitTest.java 97a9305
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationDUnitTest.java ea83a66
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationPart2DUnitTest.java b633865
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationTestCase.java 191ea3e
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationDUnitTest.java eeb2c39
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTestCase.java 088dec4
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientMultiUserAuthzDUnitTest.java 441d52c
> geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientAuthorizationDUnitTest.java 904a53c
> geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientPostAuthorizationDUnitTest.java 222ea00
> geode-core/src/test/java/com/gemstone/gemfire/security/GemFireSecurityExceptionTest.java 0c048d3
> geode-core/src/test/java/com/gemstone/gemfire/security/NotAuthorizedExceptionTest.java c5e0ba5
> geode-core/src/test/java/com/gemstone/gemfire/security/P2PAuthenticationDUnitTest.java 1db599f
> geode-core/src/test/java/com/gemstone/gemfire/security/SecurityTestUtils.java 663a17d
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/AuthzCredentialGenerator.java f39fc84
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/CredentialGenerator.java aee7ebb
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/DummyCredentialGenerator.java b709dbc
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/LdapUserCredentialGenerator.java bbd9528
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/PKCSCredentialGenerator.java 6d33493
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/SSLCredentialGenerator.java ff23f78
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/UserPasswordWithExtraPropsAuthInit.java b29f16b
> geode-core/src/test/java/com/gemstone/gemfire/security/generator/XmlAuthzCredentialGenerator.java 5d07004
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/DummyAuthorization.java a76a46f
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/LdapUserAuthenticator.java fd2286e
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSAuthInit.java 0b38a7b
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSAuthenticator.java 971cf60
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSPrincipalTest.java e0bc1e4
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/UserPasswordAuthInit.java 34161ac
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/UsernamePrincipalTest.java e762d06
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/XmlAuthorization.java b8f2e50
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/XmlErrorHandler.java 19d10c6
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/AsyncInvocation.java a612f87
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestCase.java c0245f2
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestUtils.java c1850de
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/ThreadUtils.java fe8f260
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/VM.java 962978f
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/Wait.java b73a25c
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/cache/internal/JUnit4CacheTestCase.java b5bd5f7
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit3DistributedTestCase.java f453e7e
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit4DistributedTestCase.java d5b5b6f
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3BasicDUnitTest.java 5130b5c
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3GetDefaultDiskStoreNameDUnitTest.java e89f66b
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3GetTestMethodNameDUnitTest.java c77843d
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3VMDUnitTest.java ac2ed7e
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4BasicDUnitTest.java 5cac3ba
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4GetDefaultDiskStoreNameDUnitTest.java 7f99bc1
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4GetTestMethodNameDUnitTest.java 93b2e86
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4VMDUnitTest.java c9d9d3c
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/DistributedRestoreSystemProperties.java 7f95fad
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/RemoteInvoker.java 98dbc2f
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ChildVM.java 06c3196
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java 216971a
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/RemoteDUnitVM.java 81c895e
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/RemoteDUnitVMIF.java 849e2f2
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/BasicDUnitTest.java b10f610
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4BasicDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4GetDefaultDiskStoreNameDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4GetTestMethodNameDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4OverridingGetPropertiesDisconnectsAllDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4VMDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java f1afdaf
> geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DurableClientCommandsDUnitTest.java 0a1f433
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTwoDUnitTest.java e2950c2
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java 0e8e57f
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientCQPostAuthorizationDUnitTest.java dfa89f9
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java ce03ac6
> geode-cq/src/test/java/com/gemstone/gemfire/security/MultiUserAPIDUnitTest.java 9e04f5f
> geode-cq/src/test/java/com/gemstone/gemfire/security/MultiUserDurableCQAuthzDUnitTest.java 632a997
> geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/FlakyTest.java PRE-CREATION
> geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/SecurityTest.java PRE-CREATION
> geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryOne.java PRE-CREATION
> geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryTest.java PRE-CREATION
> geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryTwo.java PRE-CREATION
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WANCommandTestBase.java 9bfce05
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandCreateGatewayReceiverDUnitTest.java 1122059
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandCreateGatewaySenderDUnitTest.java 2c99ad3
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewayReceiverStartDUnitTest.java 6f26e3b
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewayReceiverStopDUnitTest.java 82ca3ba
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewaySenderStartDUnitTest.java a10a926
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewaySenderStopDUnitTest.java f0e51bf
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandListDUnitTest.java 8880348
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandPauseResumeDUnitTest.java 360f2ab
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandStatusDUnitTest.java 12d81d7
> geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java 43caf90
>
> Diff: https://reviews.apache.org/r/45759/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 45759: GEODE-1162: convert all CLI command DUnit
tests to JUnit 4
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45759/
-----------------------------------------------------------
(Updated April 14, 2016, 8:48 p.m.)
Review request for geode, Jens Deppe and Jinmei Liao.
Changes
-------
Updated diff with final changes pushed to develop
Bugs: GEODE-1161 and GEODE-1162
https://issues.apache.org/jira/browse/GEODE-1161
https://issues.apache.org/jira/browse/GEODE-1162
Repository: geode
Description
-------
GEODE-1162: convert all CLI command DUnit tests to JUnit 4
* GEODE-1161: cleanup VM and AsyncInvocation in DUnit
* define FlakyTest JUnit category
* define SecurityTest JUnit category and apply to all security tests (probably missed a few)
* create category test to discover JUnit behavior
Diffs (updated)
-----
geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java e41e118
geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java edd056b
geode-core/src/main/java/com/gemstone/gemfire/internal/lang/ThrowableUtils.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/SelectStarQueryDUnitTest.java b92426a
geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java 8f4740c
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/ShutdownAllDUnitTest.java a1ba6d2
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/persistence/PersistentRecoveryOrderDUnitTest.java 321fffe
geode-core/src/test/java/com/gemstone/gemfire/internal/lang/ThrowableUtilsTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/AbstractCommandsSupportJUnitTest.java 8d9971e
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 7d8dc55
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java 7cfb693
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java 10b37c1
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java b70b9fa
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 566977c
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsJUnitTest.java 4b9f4c6
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/FunctionCommandsDUnitTest.java 8451916
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 7151ffd
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GetCommandOnRegionWithCacheLoaderDuringCacheMissDUnitTest.java 6704979
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HTTPServiceSSLSupportJUnitTest.java 49f405c
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 431c6b3
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsJUnitTest.java bf77aba
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeDiskStoreCommandsDUnitTest.java 744824f
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java 2d11491
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListIndexCommandDUnitTest.java caa33fb
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MemberCommandsDUnitTest.java 44cead8
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java d44a479
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java b9178b6
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart2DUnitTest.java 678af5a
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java 361a8d1
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart4DUnitTest.java 360ba08
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommandsDUnitTest.java c4d1f93
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java 5805853
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java ee6fcac
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowDeadlockDUnitTest.java 6bf05b3
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowMetricsDUnitTest.java 90d0eed
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowStackTraceDUnitTest.java 9a72d36
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/UserCommandsDUnitTest.java 97a9305
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationDUnitTest.java ea83a66
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationPart2DUnitTest.java b633865
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationTestCase.java 191ea3e
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationDUnitTest.java eeb2c39
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTestCase.java 088dec4
geode-core/src/test/java/com/gemstone/gemfire/security/ClientMultiUserAuthzDUnitTest.java 441d52c
geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientAuthorizationDUnitTest.java 904a53c
geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientPostAuthorizationDUnitTest.java 222ea00
geode-core/src/test/java/com/gemstone/gemfire/security/GemFireSecurityExceptionTest.java 0c048d3
geode-core/src/test/java/com/gemstone/gemfire/security/NotAuthorizedExceptionTest.java c5e0ba5
geode-core/src/test/java/com/gemstone/gemfire/security/P2PAuthenticationDUnitTest.java 1db599f
geode-core/src/test/java/com/gemstone/gemfire/security/SecurityTestUtils.java 663a17d
geode-core/src/test/java/com/gemstone/gemfire/security/generator/AuthzCredentialGenerator.java f39fc84
geode-core/src/test/java/com/gemstone/gemfire/security/generator/CredentialGenerator.java aee7ebb
geode-core/src/test/java/com/gemstone/gemfire/security/generator/DummyCredentialGenerator.java b709dbc
geode-core/src/test/java/com/gemstone/gemfire/security/generator/LdapUserCredentialGenerator.java bbd9528
geode-core/src/test/java/com/gemstone/gemfire/security/generator/PKCSCredentialGenerator.java 6d33493
geode-core/src/test/java/com/gemstone/gemfire/security/generator/SSLCredentialGenerator.java ff23f78
geode-core/src/test/java/com/gemstone/gemfire/security/generator/UserPasswordWithExtraPropsAuthInit.java b29f16b
geode-core/src/test/java/com/gemstone/gemfire/security/generator/XmlAuthzCredentialGenerator.java 5d07004
geode-core/src/test/java/com/gemstone/gemfire/security/templates/DummyAuthorization.java a76a46f
geode-core/src/test/java/com/gemstone/gemfire/security/templates/LdapUserAuthenticator.java fd2286e
geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSAuthInit.java 0b38a7b
geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSAuthenticator.java 971cf60
geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSPrincipalTest.java e0bc1e4
geode-core/src/test/java/com/gemstone/gemfire/security/templates/UserPasswordAuthInit.java 34161ac
geode-core/src/test/java/com/gemstone/gemfire/security/templates/UsernamePrincipalTest.java e762d06
geode-core/src/test/java/com/gemstone/gemfire/security/templates/XmlAuthorization.java b8f2e50
geode-core/src/test/java/com/gemstone/gemfire/security/templates/XmlErrorHandler.java 19d10c6
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/AsyncInvocation.java a612f87
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestCase.java c0245f2
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestUtils.java c1850de
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/ThreadUtils.java fe8f260
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/VM.java 962978f
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/Wait.java b73a25c
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/cache/internal/JUnit4CacheTestCase.java b5bd5f7
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit3DistributedTestCase.java f453e7e
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit4DistributedTestCase.java 2c93ddf
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3BasicDUnitTest.java 5130b5c
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3GetDefaultDiskStoreNameDUnitTest.java e89f66b
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3GetTestMethodNameDUnitTest.java c77843d
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3VMDUnitTest.java ac2ed7e
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4BasicDUnitTest.java 5cac3ba
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4GetDefaultDiskStoreNameDUnitTest.java 7f99bc1
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4GetTestMethodNameDUnitTest.java 93b2e86
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4VMDUnitTest.java c9d9d3c
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/DistributedRestoreSystemProperties.java 7f95fad
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/RemoteInvoker.java 98dbc2f
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ChildVM.java 06c3196
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java 216971a
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/RemoteDUnitVM.java 81c895e
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/RemoteDUnitVMIF.java 849e2f2
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/BasicDUnitTest.java b10f610
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4BasicDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4GetDefaultDiskStoreNameDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4GetTestMethodNameDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4OverridingGetPropertiesDisconnectsAllDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4VMDUnitTest.java PRE-CREATION
geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java f1afdaf
geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DurableClientCommandsDUnitTest.java 0a1f433
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTwoDUnitTest.java e2950c2
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java 0e8e57f
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientCQPostAuthorizationDUnitTest.java dfa89f9
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java ce03ac6
geode-cq/src/test/java/com/gemstone/gemfire/security/MultiUserAPIDUnitTest.java 9e04f5f
geode-cq/src/test/java/com/gemstone/gemfire/security/MultiUserDurableCQAuthzDUnitTest.java 632a997
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/FlakyTest.java PRE-CREATION
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/SecurityTest.java PRE-CREATION
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/RetryRule.java 8535fa5
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryOne.java PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryTest.java PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryTwo.java PRE-CREATION
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WANCommandTestBase.java 9bfce05
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandCreateGatewayReceiverDUnitTest.java 1122059
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandCreateGatewaySenderDUnitTest.java 2c99ad3
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewayReceiverStartDUnitTest.java 6f26e3b
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewayReceiverStopDUnitTest.java 82ca3ba
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewaySenderStartDUnitTest.java a10a926
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewaySenderStopDUnitTest.java f0e51bf
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandListDUnitTest.java 8880348
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandPauseResumeDUnitTest.java 360f2ab
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandStatusDUnitTest.java 12d81d7
geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java 43caf90
Diff: https://reviews.apache.org/r/45759/diff/
Testing
-------
precheckin
Thanks,
Kirk Lund
Re: Review Request 45759: GEODE-1162: convert all CLI command DUnit
tests to JUnit 4
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45759/
-----------------------------------------------------------
(Updated April 5, 2016, 7:49 p.m.)
Review request for geode, Jens Deppe and Jinmei Liao.
Changes
-------
Deleted some dead code and restored final keyword on a couple methods
Bugs: GEODE-1161 and GEODE-1162
https://issues.apache.org/jira/browse/GEODE-1161
https://issues.apache.org/jira/browse/GEODE-1162
Repository: geode
Description
-------
GEODE-1162: convert all CLI command DUnit tests to JUnit 4
* GEODE-1161: cleanup VM and AsyncInvocation in DUnit
* define FlakyTest JUnit category
* define SecurityTest JUnit category and apply to all security tests (probably missed a few)
* create category test to discover JUnit behavior
Diffs (updated)
-----
geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java 2344155
geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java edd056b
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/AbstractCommandsSupportJUnitTest.java 8d9971e
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 7d8dc55
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java 7cfb693
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java 10b37c1
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java b70b9fa
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 566977c
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsJUnitTest.java 4b9f4c6
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/FunctionCommandsDUnitTest.java 8451916
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 7151ffd
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GetCommandOnRegionWithCacheLoaderDuringCacheMissDUnitTest.java 6704979
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HTTPServiceSSLSupportJUnitTest.java 49f405c
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 431c6b3
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsJUnitTest.java bf77aba
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeDiskStoreCommandsDUnitTest.java 744824f
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java 2d11491
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListIndexCommandDUnitTest.java caa33fb
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MemberCommandsDUnitTest.java 44cead8
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java d44a479
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java b9178b6
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart2DUnitTest.java 678af5a
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java 361a8d1
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart4DUnitTest.java 360ba08
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommandsDUnitTest.java c4d1f93
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java 5805853
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java ee6fcac
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowDeadlockDUnitTest.java 6bf05b3
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowMetricsDUnitTest.java 90d0eed
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowStackTraceDUnitTest.java 9a72d36
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/UserCommandsDUnitTest.java 97a9305
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationDUnitTest.java ea83a66
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationPart2DUnitTest.java b633865
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationTestCase.java 191ea3e
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationDUnitTest.java eeb2c39
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTestCase.java 088dec4
geode-core/src/test/java/com/gemstone/gemfire/security/ClientMultiUserAuthzDUnitTest.java 441d52c
geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientAuthorizationDUnitTest.java 904a53c
geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientPostAuthorizationDUnitTest.java 222ea00
geode-core/src/test/java/com/gemstone/gemfire/security/GemFireSecurityExceptionTest.java 0c048d3
geode-core/src/test/java/com/gemstone/gemfire/security/NotAuthorizedExceptionTest.java c5e0ba5
geode-core/src/test/java/com/gemstone/gemfire/security/P2PAuthenticationDUnitTest.java 1db599f
geode-core/src/test/java/com/gemstone/gemfire/security/SecurityTestUtils.java 663a17d
geode-core/src/test/java/com/gemstone/gemfire/security/generator/AuthzCredentialGenerator.java f39fc84
geode-core/src/test/java/com/gemstone/gemfire/security/generator/CredentialGenerator.java aee7ebb
geode-core/src/test/java/com/gemstone/gemfire/security/generator/DummyCredentialGenerator.java b709dbc
geode-core/src/test/java/com/gemstone/gemfire/security/generator/LdapUserCredentialGenerator.java bbd9528
geode-core/src/test/java/com/gemstone/gemfire/security/generator/PKCSCredentialGenerator.java 6d33493
geode-core/src/test/java/com/gemstone/gemfire/security/generator/SSLCredentialGenerator.java ff23f78
geode-core/src/test/java/com/gemstone/gemfire/security/generator/UserPasswordWithExtraPropsAuthInit.java b29f16b
geode-core/src/test/java/com/gemstone/gemfire/security/generator/XmlAuthzCredentialGenerator.java 5d07004
geode-core/src/test/java/com/gemstone/gemfire/security/templates/DummyAuthorization.java a76a46f
geode-core/src/test/java/com/gemstone/gemfire/security/templates/LdapUserAuthenticator.java fd2286e
geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSAuthInit.java 0b38a7b
geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSAuthenticator.java 971cf60
geode-core/src/test/java/com/gemstone/gemfire/security/templates/PKCSPrincipalTest.java e0bc1e4
geode-core/src/test/java/com/gemstone/gemfire/security/templates/UserPasswordAuthInit.java 34161ac
geode-core/src/test/java/com/gemstone/gemfire/security/templates/UsernamePrincipalTest.java e762d06
geode-core/src/test/java/com/gemstone/gemfire/security/templates/XmlAuthorization.java b8f2e50
geode-core/src/test/java/com/gemstone/gemfire/security/templates/XmlErrorHandler.java 19d10c6
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/AsyncInvocation.java a612f87
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestCase.java c0245f2
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestUtils.java c1850de
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/ThreadUtils.java fe8f260
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/VM.java 962978f
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/Wait.java b73a25c
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/cache/internal/JUnit4CacheTestCase.java b5bd5f7
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit3DistributedTestCase.java f453e7e
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/JUnit4DistributedTestCase.java d5b5b6f
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3BasicDUnitTest.java 5130b5c
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3GetDefaultDiskStoreNameDUnitTest.java e89f66b
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3GetTestMethodNameDUnitTest.java c77843d
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit3VMDUnitTest.java ac2ed7e
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4BasicDUnitTest.java 5cac3ba
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4GetDefaultDiskStoreNameDUnitTest.java 7f99bc1
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4GetTestMethodNameDUnitTest.java 93b2e86
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/internal/tests/JUnit4VMDUnitTest.java c9d9d3c
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/DistributedRestoreSystemProperties.java 7f95fad
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/RemoteInvoker.java 98dbc2f
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ChildVM.java 06c3196
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java 216971a
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/RemoteDUnitVM.java 81c895e
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/RemoteDUnitVMIF.java 849e2f2
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/BasicDUnitTest.java b10f610
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4BasicDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4GetDefaultDiskStoreNameDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4GetTestMethodNameDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4OverridingGetPropertiesDisconnectsAllDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/tests/JUnit4VMDUnitTest.java PRE-CREATION
geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java f1afdaf
geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DurableClientCommandsDUnitTest.java 0a1f433
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTwoDUnitTest.java e2950c2
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java 0e8e57f
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientCQPostAuthorizationDUnitTest.java dfa89f9
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java ce03ac6
geode-cq/src/test/java/com/gemstone/gemfire/security/MultiUserAPIDUnitTest.java 9e04f5f
geode-cq/src/test/java/com/gemstone/gemfire/security/MultiUserDurableCQAuthzDUnitTest.java 632a997
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/FlakyTest.java PRE-CREATION
geode-junit/src/main/java/com/gemstone/gemfire/test/junit/categories/SecurityTest.java PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryOne.java PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryTest.java PRE-CREATION
geode-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/CategoryTwo.java PRE-CREATION
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WANCommandTestBase.java 9bfce05
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandCreateGatewayReceiverDUnitTest.java 1122059
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandCreateGatewaySenderDUnitTest.java 2c99ad3
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewayReceiverStartDUnitTest.java 6f26e3b
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewayReceiverStopDUnitTest.java 82ca3ba
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewaySenderStartDUnitTest.java a10a926
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewaySenderStopDUnitTest.java f0e51bf
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandListDUnitTest.java 8880348
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandPauseResumeDUnitTest.java 360f2ab
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandStatusDUnitTest.java 12d81d7
geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java 43caf90
Diff: https://reviews.apache.org/r/45759/diff/
Testing
-------
precheckin
Thanks,
Kirk Lund