You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/10/14 16:59:49 UTC
[GitHub] [drill] jduo commented on a change in pull request #2107: DRILL-7795: Add support for overriding hostname to C++ client
jduo commented on a change in pull request #2107:
URL: https://github.com/apache/drill/pull/2107#discussion_r504833233
##########
File path: contrib/native/client/src/clientlib/errmsgs.hpp
##########
@@ -59,7 +59,8 @@ namespace Drill{
#define ERR_CONN_SSL_CN DRILL_ERR_START+27
#define ERR_CONN_SSL_CERTVERIFY DRILL_ERR_START+28
#define ERR_CONN_SSL_PROTOVER DRILL_ERR_START+29
-#define ERR_CONN_MAX DRILL_ERR_START+29
+#define ERR_CONN_SSL_SNI DRILL_ERR_START+30
+#define ERR_CONN_MAX DRILL_ERR_START+30
Review comment:
Looking through the history, it looks like ERR_CONN_MAX is always set the value of the highest ERR_CONN code (as in it is an inclusive boundary, not exclusive boundary). So this seems like it should be DRILL_ERR_START+30
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org