You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2005/05/15 23:11:34 UTC

[jira] Created: (MNG-394) repoclean overwrites valid poms with dummy poms when there was none in m1 repo

repoclean overwrites valid poms with dummy poms when there was none in m1 repo
------------------------------------------------------------------------------

         Key: MNG-394
         URL: http://jira.codehaus.org/browse/MNG-394
     Project: m2
        Type: Bug
  Components: repository-tools  
    Reporter: Brett Porter


I copied the wagon JARs from the m2 repo to the m1 repo so that m1 users could access them. However, repoclean detected they were newer and "converted" them, copying the JARs back to the original location where they already resided, and overwriting valid m2 poms with dummy groupId/artifactId only POMs because there were none in the m1 repo.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MRM-4) repoclean overwrites valid poms with dummy poms when there was none in m1 repo

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-4?page=all ]
     
John Casey closed MRM-4:
------------------------

    Resolution: Fixed

check before writing the generated pom to the target file, and ALWAYS attempt to verify/patch the checksums for the target pom.

> repoclean overwrites valid poms with dummy poms when there was none in m1 repo
> ------------------------------------------------------------------------------
>
>          Key: MRM-4
>          URL: http://jira.codehaus.org/browse/MRM-4
>      Project: Maven Repository Manager
>         Type: Bug
>   Components: repository-converter
>     Reporter: Brett Porter
>     Assignee: John Casey

>
>
> I copied the wagon JARs from the m2 repo to the m1 repo so that m1 users could access them. However, repoclean detected they were newer and "converted" them, copying the JARs back to the original location where they already resided, and overwriting valid m2 poms with dummy groupId/artifactId only POMs because there were none in the m1 repo.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MRM-4) repoclean overwrites valid poms with dummy poms when there was none in m1 repo

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-4?page=comments#action_40823 ]
     
John Casey commented on MRM-4:
------------------------------

shouldn't we opt to publish to the m1 repo and let the converter push it across instead of putting in this check? We talked about this at one time on IRC...

One thing: for m2 devs, the lag time involved in this push-and-convert process may be too much...perhaps we need to figure out an easy way to trigger priority conversions when such artifacts are deployed...? Just an idea.

> repoclean overwrites valid poms with dummy poms when there was none in m1 repo
> ------------------------------------------------------------------------------
>
>          Key: MRM-4
>          URL: http://jira.codehaus.org/browse/MRM-4
>      Project: Maven Repository Manager
>         Type: Bug
>   Components: repository-converter
>     Reporter: Brett Porter
>     Assignee: John Casey

>
>
> I copied the wagon JARs from the m2 repo to the m1 repo so that m1 users could access them. However, repoclean detected they were newer and "converted" them, copying the JARs back to the original location where they already resided, and overwriting valid m2 poms with dummy groupId/artifactId only POMs because there were none in the m1 repo.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [jira] Commented: (MRM-4) repoclean overwrites valid poms with dummy poms when there was none in m1 repo

Posted by John Casey <jd...@commonjava.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

...which was exactly my point. I'll implement this later today, when I
get the profiles ITs done.

Brett Porter wrote:
> This doesn't need to be complicated, do timestamp checks, or anything -
> it is just when there is no pom at the source, don't create a fake one
> at the dest, if it already exists. If there is one at the source, its
> fine to do a conversion.
> 
> - Brett
> 
> John Casey wrote:
> 
>> it already does so, based on the artifact itself's lastMod time...this
>> is why the POM check is getting messed up...the artifact has changed, so
>> repoclean processes it without any regard for what's already there WRT
>> the POM...
>>
>> That's what we need to make more intelligent, I think.
>>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 
> 
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQFCqEYmK3h2CZwO/4URAjvzAKCUQyPDpGo6HDDR47qCf8miPVpeFACdFYqV
XTXbXsHM3YidCspnbnkU0WE=
=x0fi
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [jira] Commented: (MRM-4) repoclean overwrites valid poms with dummy poms when there was none in m1 repo

Posted by Brett Porter <br...@apache.org>.
This doesn't need to be complicated, do timestamp checks, or anything - 
it is just when there is no pom at the source, don't create a fake one 
at the dest, if it already exists. If there is one at the source, its 
fine to do a conversion.

- Brett

John Casey wrote:

> it already does so, based on the artifact itself's lastMod time...this
> is why the POM check is getting messed up...the artifact has changed, so
> repoclean processes it without any regard for what's already there WRT
> the POM...
>
> That's what we need to make more intelligent, I think.
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [jira] Commented: (MRM-4) repoclean overwrites valid poms with dummy poms when there was none in m1 repo

Posted by John Casey <jd...@commonjava.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

it already does so, based on the artifact itself's lastMod time...this
is why the POM check is getting messed up...the artifact has changed, so
repoclean processes it without any regard for what's already there WRT
the POM...

That's what we need to make more intelligent, I think.

Trygve Laugstol (JIRA) wrote:
>      [ http://jira.codehaus.org/browse/MRM-4?page=comments#action_40874 ]
>      
> Trygve Laugstol commented on MRM-4:
> -----------------------------------
> 
> John: Is is possible to have a process that scans for changed/new artifacts only and processes them? Is so, is this process any less disk intensive (which determines the run time of the process)? 
> 
> 
>>repoclean overwrites valid poms with dummy poms when there was none in m1 repo
>>------------------------------------------------------------------------------
>>
>>         Key: MRM-4
>>         URL: http://jira.codehaus.org/browse/MRM-4
>>     Project: Maven Repository Manager
>>        Type: Bug
>>  Components: repository-converter
>>    Reporter: Brett Porter
>>    Assignee: John Casey
> 
> 
>>
>>I copied the wagon JARs from the m2 repo to the m1 repo so that m1 users could access them. However, repoclean detected they were newer and "converted" them, copying the JARs back to the original location where they already resided, and overwriting valid m2 poms with dummy groupId/artifactId only POMs because there were none in the m1 repo.
> 
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQFCqBwlK3h2CZwO/4URAhApAJ0ehtTmsBZaDMDv9yNEijj3QifUFQCffmSf
EBIfLs5NRIW15OFr332VHL0=
=3WWw
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MRM-4) repoclean overwrites valid poms with dummy poms when there was none in m1 repo

Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-4?page=comments#action_40874 ]
     
Trygve Laugstol commented on MRM-4:
-----------------------------------

John: Is is possible to have a process that scans for changed/new artifacts only and processes them? Is so, is this process any less disk intensive (which determines the run time of the process)? 

> repoclean overwrites valid poms with dummy poms when there was none in m1 repo
> ------------------------------------------------------------------------------
>
>          Key: MRM-4
>          URL: http://jira.codehaus.org/browse/MRM-4
>      Project: Maven Repository Manager
>         Type: Bug
>   Components: repository-converter
>     Reporter: Brett Porter
>     Assignee: John Casey

>
>
> I copied the wagon JARs from the m2 repo to the m1 repo so that m1 users could access them. However, repoclean detected they were newer and "converted" them, copying the JARs back to the original location where they already resided, and overwriting valid m2 poms with dummy groupId/artifactId only POMs because there were none in the m1 repo.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MRM-4) repoclean overwrites valid poms with dummy poms when there was none in m1 repo

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-4?page=comments#action_40839 ]
     
Brett Porter commented on MRM-4:
--------------------------------

I think the proper solution is to publish to m2 and convert back to m1 - but you indicated that would be quite a bit harder as it is currently only design to run over an m1 repo.

I think this is still a bug. Publishing to m1 with no POM should not get rid of valid info in the m2 repo.

> repoclean overwrites valid poms with dummy poms when there was none in m1 repo
> ------------------------------------------------------------------------------
>
>          Key: MRM-4
>          URL: http://jira.codehaus.org/browse/MRM-4
>      Project: Maven Repository Manager
>         Type: Bug
>   Components: repository-converter
>     Reporter: Brett Porter
>     Assignee: John Casey

>
>
> I copied the wagon JARs from the m2 repo to the m1 repo so that m1 users could access them. However, repoclean detected they were newer and "converted" them, copying the JARs back to the original location where they already resided, and overwriting valid m2 poms with dummy groupId/artifactId only POMs because there were none in the m1 repo.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org