You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by sebastianrothbucher <gi...@git.apache.org> on 2016/04/21 18:43:35 UTC

[GitHub] couchdb pull request: More test improvements and stabilization

GitHub user sebastianrothbucher opened a pull request:

    https://github.com/apache/couchdb/pull/409

    More test improvements and stabilization

    I did put in some more work to get the tests more stable - esp. replication.js (use random-generated databases throughout), the users_db / show_functions / and some other tests are back also. 
    
    For n=1, it seems to be pretty stable already (also on lower computing power), for n=3 there's still work left (so is for the replication_db... tests; however: the core tests would be there already)
    
    we should certainly merge after the RC1, any feedback is welcome still (it makes lots of sense to rebase after #400 and #401 is in - in fact merging them should be done before as this PR depends on them)
    
    BTW: I sat down and drafted a short blog post on my lessons learned so far - any feedback highly welcome: https://gist.github.com/sebastianrothbucher/5e30ebbd98c64330f61ce87a9b8a4d00

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sebastianrothbucher/couchdb test4th

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/409.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #409
    
----
commit 73cf6cea66f188c7c2d0cee277689ee9557d96d2
Author: sebastianro <se...@apache.org>
Date:   2016-04-15T12:49:25Z

    Bring show documents test back

commit d94a38d90516d9b7c6666e10d9ff8e8ecd21235a
Author: sebastianro <se...@apache.org>
Date:   2016-04-15T13:43:34Z

    Bring users DB test back - unfortunately still work 2 do

commit b1f81f7aea0ea62a3260c20d6e774c6ec74ecb28
Author: sebastianro <se...@apache.org>
Date:   2016-04-15T16:15:26Z

    Bring include docs back (and link jira to userdb sec)

commit 1c02c4813fb14950e56c60930eb070be5308cb45
Author: sebastianro <se...@apache.org>
Date:   2016-04-15T16:37:35Z

    Bring multi key design test back

commit aef746d619c4ecd11b1e6f988477b7b19b60a2be
Author: sebastianro <se...@apache.org>
Date:   2016-04-21T14:21:47Z

    Make sure we have random DB names all around including replication test and stabilize show_documents

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: More test improvements and stabilization

Posted by janl <gi...@git.apache.org>.
Github user janl commented on the pull request:

    https://github.com/apache/couchdb/pull/409#issuecomment-213715641
  
    After applying #400 and #401 to master (nice work!) and rebasing the new master on top of this locally, I get reproducible test fails in `rewrite_js` and `show_documents`, and intermittent failures in `view_sandboxing` (sometimes it passes, sometimes not.
    
    These are the errors:
    
    ```
    test/javascript/tests/rewrite_js.js                            
        Error: false
    Trace back (most recent call first):
        
      52: test/javascript/test_setup.js
          T(false)
     305: test/javascript/tests/rewrite_js.js
          ()
      37: test/javascript/cli_runner.js
          runTest()
      48: test/javascript/cli_runner.js
    ```
    
    ```
    test/javascript/tests/show_documents.js                        
        Error: retry_part is not defined
    Trace back (most recent call first):
        
     400: test/javascript/tests/show_documents.js
          ()
      37: test/javascript/cli_runner.js
          runTest()
      48: test/javascript/cli_runner.js
    ```
    
    ```
    test/javascript/tests/view_sandboxing.js                       
        Error: expected '1', got 'null'
    Trace back (most recent call first):
        
      52: test/javascript/test_setup.js
          T(false,"expected '1', got 'null'",(void 0))
     321: test/javascript/couch_test_runner.js
          TEquals(1,(void 0))
     129: test/javascript/tests/view_sandboxing.js
          ()
      37: test/javascript/cli_runner.js
          runTest()
      48: test/javascript/cli_runner.js
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: More test improvements and stabilization

Posted by sebastianrothbucher <gi...@git.apache.org>.
Github user sebastianrothbucher commented on the pull request:

    https://github.com/apache/couchdb/pull/409#issuecomment-213797006
  
    @janl thx 4 checking; I did a rebase against master (see above) and that knocks off two errors right away. I did improve what went wrong for show_documents as well. You can re-try some time (and CU in 30mins or so ;-) )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: More test improvements and stabilization

Posted by janl <gi...@git.apache.org>.
Github user janl commented on the pull request:

    https://github.com/apache/couchdb/pull/409#issuecomment-213852770
  
    this is relevant: https://github.com/apache/couchdb-chttpd/pull/116


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: More test improvements and stabilization

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/couchdb/pull/409


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: More test improvements and stabilization

Posted by sebastianrothbucher <gi...@git.apache.org>.
Github user sebastianrothbucher commented on the pull request:

    https://github.com/apache/couchdb/pull/409#issuecomment-213945849
  
    Done & pushed ;-) (I did checkout chttpd's 116, make and make javascript) successfully. Just created a full new user so we won't hit the cache 4 sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---