You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Nick Dimiduk (JIRA)" <ji...@apache.org> on 2014/12/18 22:24:14 UTC
[jira] [Updated] (HBASE-11983) HRegion constructors should not
create HLog
[ https://issues.apache.org/jira/browse/HBASE-11983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Dimiduk updated HBASE-11983:
---------------------------------
Attachment: HBASE-11983.00.patch
Here's a refactor patch. HRegion now requires providing a WAL. HBaseTestingUtility has methods for creating a region and a wal for that region. The helper method for closing a region and it's wal is also moved to HBaseTestingUtility.
> HRegion constructors should not create HLog
> --------------------------------------------
>
> Key: HBASE-11983
> URL: https://issues.apache.org/jira/browse/HBASE-11983
> Project: HBase
> Issue Type: Bug
> Components: wal
> Reporter: Enis Soztutar
> Assignee: Sean Busbey
> Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-11983.00.patch
>
>
> We should get rid of HRegion creating its own HLog. It should ALWAYS get the log from outside.
> I think this was added for unit tests, but we should refrain from such practice in the future (adding UT constructors always leads to weird and critical bugs down the road). See recent: HBASE-11982, HBASE-11654.
> Get rid of weird things like ignoreHLog:
> {code}
> /**
> * @param ignoreHLog - true to skip generate new hlog if it is null, mostly for createTable
> */
> public static HRegion createHRegion(final HRegionInfo info, final Path rootDir,
> final Configuration conf,
> final HTableDescriptor hTableDescriptor,
> final HLog hlog,
> final boolean initialize, final boolean ignoreHLog)
> {code}
> We can unify all the createXX and newXX methods and separate creating a region in the file system vs opening a region.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)