You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/07/15 00:22:59 UTC
Review Request 23461: Added 'bool' return value to Containerizer::launch.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23461/
-----------------------------------------------------------
Review request for mesos, Ian Downes and Jie Yu.
Bugs: MESOS-1527
https://issues.apache.org/jira/browse/MESOS-1527
Repository: mesos-git
Description
-------
See summary and JIRA issue. tl;dr; We need a way of determining whether or not a containerizer could try and launch a container for a task/executor. The most simple API change here was swapping Nothing => bool, see comments on 'Containerizer::launch'.
Diffs
-----
src/slave/containerizer/containerizer.hpp a9f89fc8f9034e80010ba21f35dad2fa098b270e
src/slave/containerizer/external_containerizer.hpp 94dffbb75a3df7dbc9aaebbc5fd121967353750d
src/slave/containerizer/external_containerizer.cpp 3f28d85972a1666c942d1d689c8f861dbf15f6aa
src/slave/containerizer/mesos/containerizer.hpp 8746968c649d9a90b5a6af4326c8b1c454446983
src/slave/containerizer/mesos/containerizer.cpp 2c394e2c8702166266f5d20ff005abb218da8a6c
src/slave/slave.hpp a896bb66db5d8cd27ef02b6498c9db93cb0d525f
src/slave/slave.cpp e81abb2e6371d052151253172a4abde7169cb72f
src/tests/containerizer.hpp 9325864691fb45d98f006f410c25f8fbd27b76bb
src/tests/containerizer.cpp 3f11d352522e7a1e9c8ca74d033c25c4ec7a6d23
src/tests/containerizer_tests.cpp 70e12455c0774c46f098cbaa2ec770305f6d6d11
src/tests/external_containerizer_test.cpp c26f3c262e60733849fbe8fbdc70a49bb55f5fff
src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e
src/tests/slave_tests.cpp 371a5b8eb3d15343418d83d8cf08591649ac807c
Diff: https://reviews.apache.org/r/23461/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 23461: Added 'bool' return value to Containerizer::launch.
Posted by Tom Arnfeld <ta...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23461/#review47869
-----------------------------------------------------------
Ship it!
- Tom Arnfeld
On July 14, 2014, 10:31 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23461/
> -----------------------------------------------------------
>
> (Updated July 14, 2014, 10:31 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Bugs: MESOS-1527
> https://issues.apache.org/jira/browse/MESOS-1527
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and JIRA issue. tl;dr; We need a way of determining whether or not a containerizer could try and launch a container for a task/executor. The most simple API change here was swapping Nothing => bool, see comments on 'Containerizer::launch'.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp a9f89fc8f9034e80010ba21f35dad2fa098b270e
> src/slave/containerizer/external_containerizer.hpp 94dffbb75a3df7dbc9aaebbc5fd121967353750d
> src/slave/containerizer/external_containerizer.cpp 3f28d85972a1666c942d1d689c8f861dbf15f6aa
> src/slave/containerizer/mesos/containerizer.hpp 8746968c649d9a90b5a6af4326c8b1c454446983
> src/slave/containerizer/mesos/containerizer.cpp 2c394e2c8702166266f5d20ff005abb218da8a6c
> src/slave/slave.hpp a896bb66db5d8cd27ef02b6498c9db93cb0d525f
> src/slave/slave.cpp e81abb2e6371d052151253172a4abde7169cb72f
> src/tests/containerizer.hpp 9325864691fb45d98f006f410c25f8fbd27b76bb
> src/tests/containerizer.cpp 3f11d352522e7a1e9c8ca74d033c25c4ec7a6d23
> src/tests/containerizer_tests.cpp 70e12455c0774c46f098cbaa2ec770305f6d6d11
> src/tests/external_containerizer_test.cpp c26f3c262e60733849fbe8fbdc70a49bb55f5fff
> src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e
> src/tests/slave_tests.cpp 371a5b8eb3d15343418d83d8cf08591649ac807c
>
> Diff: https://reviews.apache.org/r/23461/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 23461: Added 'bool' return value to Containerizer::launch.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23461/#review47822
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On July 14, 2014, 10:31 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23461/
> -----------------------------------------------------------
>
> (Updated July 14, 2014, 10:31 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Bugs: MESOS-1527
> https://issues.apache.org/jira/browse/MESOS-1527
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and JIRA issue. tl;dr; We need a way of determining whether or not a containerizer could try and launch a container for a task/executor. The most simple API change here was swapping Nothing => bool, see comments on 'Containerizer::launch'.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp a9f89fc8f9034e80010ba21f35dad2fa098b270e
> src/slave/containerizer/external_containerizer.hpp 94dffbb75a3df7dbc9aaebbc5fd121967353750d
> src/slave/containerizer/external_containerizer.cpp 3f28d85972a1666c942d1d689c8f861dbf15f6aa
> src/slave/containerizer/mesos/containerizer.hpp 8746968c649d9a90b5a6af4326c8b1c454446983
> src/slave/containerizer/mesos/containerizer.cpp 2c394e2c8702166266f5d20ff005abb218da8a6c
> src/slave/slave.hpp a896bb66db5d8cd27ef02b6498c9db93cb0d525f
> src/slave/slave.cpp e81abb2e6371d052151253172a4abde7169cb72f
> src/tests/containerizer.hpp 9325864691fb45d98f006f410c25f8fbd27b76bb
> src/tests/containerizer.cpp 3f11d352522e7a1e9c8ca74d033c25c4ec7a6d23
> src/tests/containerizer_tests.cpp 70e12455c0774c46f098cbaa2ec770305f6d6d11
> src/tests/external_containerizer_test.cpp c26f3c262e60733849fbe8fbdc70a49bb55f5fff
> src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e
> src/tests/slave_tests.cpp 371a5b8eb3d15343418d83d8cf08591649ac807c
>
> Diff: https://reviews.apache.org/r/23461/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 23461: Added 'bool' return value to Containerizer::launch.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23461/
-----------------------------------------------------------
(Updated July 14, 2014, 10:31 p.m.)
Review request for mesos, Ian Downes and Jie Yu.
Bugs: MESOS-1527
https://issues.apache.org/jira/browse/MESOS-1527
Repository: mesos-git
Description (updated)
-------
See summary and JIRA issue. tl;dr; We need a way of determining whether or not a containerizer could try and launch a container for a task/executor. The most simple API change here was swapping Nothing => bool, see comments on 'Containerizer::launch'.
Diffs
-----
src/slave/containerizer/containerizer.hpp a9f89fc8f9034e80010ba21f35dad2fa098b270e
src/slave/containerizer/external_containerizer.hpp 94dffbb75a3df7dbc9aaebbc5fd121967353750d
src/slave/containerizer/external_containerizer.cpp 3f28d85972a1666c942d1d689c8f861dbf15f6aa
src/slave/containerizer/mesos/containerizer.hpp 8746968c649d9a90b5a6af4326c8b1c454446983
src/slave/containerizer/mesos/containerizer.cpp 2c394e2c8702166266f5d20ff005abb218da8a6c
src/slave/slave.hpp a896bb66db5d8cd27ef02b6498c9db93cb0d525f
src/slave/slave.cpp e81abb2e6371d052151253172a4abde7169cb72f
src/tests/containerizer.hpp 9325864691fb45d98f006f410c25f8fbd27b76bb
src/tests/containerizer.cpp 3f11d352522e7a1e9c8ca74d033c25c4ec7a6d23
src/tests/containerizer_tests.cpp 70e12455c0774c46f098cbaa2ec770305f6d6d11
src/tests/external_containerizer_test.cpp c26f3c262e60733849fbe8fbdc70a49bb55f5fff
src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e
src/tests/slave_tests.cpp 371a5b8eb3d15343418d83d8cf08591649ac807c
Diff: https://reviews.apache.org/r/23461/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 23461: Added 'bool' return value to Containerizer::launch.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23461/
-----------------------------------------------------------
(Updated July 14, 2014, 10:29 p.m.)
Review request for mesos, Ian Downes and Jie Yu.
Bugs: MESOS-1527
https://issues.apache.org/jira/browse/MESOS-1527
Repository: mesos-git
Description (updated)
-------
See summary and JIRA issue. tl;dr; We need a way of determining whether or not a containerizer could try and launch a container for a task/executor. The most simple API change here was swapping Nothing => bool, see comments on 'Containerizer::launch'.
Note that there is a bug fixed in review 23464.
Diffs
-----
src/slave/containerizer/containerizer.hpp a9f89fc8f9034e80010ba21f35dad2fa098b270e
src/slave/containerizer/external_containerizer.hpp 94dffbb75a3df7dbc9aaebbc5fd121967353750d
src/slave/containerizer/external_containerizer.cpp 3f28d85972a1666c942d1d689c8f861dbf15f6aa
src/slave/containerizer/mesos/containerizer.hpp 8746968c649d9a90b5a6af4326c8b1c454446983
src/slave/containerizer/mesos/containerizer.cpp 2c394e2c8702166266f5d20ff005abb218da8a6c
src/slave/slave.hpp a896bb66db5d8cd27ef02b6498c9db93cb0d525f
src/slave/slave.cpp e81abb2e6371d052151253172a4abde7169cb72f
src/tests/containerizer.hpp 9325864691fb45d98f006f410c25f8fbd27b76bb
src/tests/containerizer.cpp 3f11d352522e7a1e9c8ca74d033c25c4ec7a6d23
src/tests/containerizer_tests.cpp 70e12455c0774c46f098cbaa2ec770305f6d6d11
src/tests/external_containerizer_test.cpp c26f3c262e60733849fbe8fbdc70a49bb55f5fff
src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e
src/tests/slave_tests.cpp 371a5b8eb3d15343418d83d8cf08591649ac807c
Diff: https://reviews.apache.org/r/23461/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 23461: Added 'bool' return value to Containerizer::launch.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23461/#review47742
-----------------------------------------------------------
Ship it!
Ship It!
- Ian Downes
On July 14, 2014, 3:22 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23461/
> -----------------------------------------------------------
>
> (Updated July 14, 2014, 3:22 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Bugs: MESOS-1527
> https://issues.apache.org/jira/browse/MESOS-1527
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and JIRA issue. tl;dr; We need a way of determining whether or not a containerizer could try and launch a container for a task/executor. The most simple API change here was swapping Nothing => bool, see comments on 'Containerizer::launch'.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp a9f89fc8f9034e80010ba21f35dad2fa098b270e
> src/slave/containerizer/external_containerizer.hpp 94dffbb75a3df7dbc9aaebbc5fd121967353750d
> src/slave/containerizer/external_containerizer.cpp 3f28d85972a1666c942d1d689c8f861dbf15f6aa
> src/slave/containerizer/mesos/containerizer.hpp 8746968c649d9a90b5a6af4326c8b1c454446983
> src/slave/containerizer/mesos/containerizer.cpp 2c394e2c8702166266f5d20ff005abb218da8a6c
> src/slave/slave.hpp a896bb66db5d8cd27ef02b6498c9db93cb0d525f
> src/slave/slave.cpp e81abb2e6371d052151253172a4abde7169cb72f
> src/tests/containerizer.hpp 9325864691fb45d98f006f410c25f8fbd27b76bb
> src/tests/containerizer.cpp 3f11d352522e7a1e9c8ca74d033c25c4ec7a6d23
> src/tests/containerizer_tests.cpp 70e12455c0774c46f098cbaa2ec770305f6d6d11
> src/tests/external_containerizer_test.cpp c26f3c262e60733849fbe8fbdc70a49bb55f5fff
> src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e
> src/tests/slave_tests.cpp 371a5b8eb3d15343418d83d8cf08591649ac807c
>
> Diff: https://reviews.apache.org/r/23461/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>