You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by majetideepak <gi...@git.apache.org> on 2018/07/30 14:27:08 UTC

[GitHub] orc pull request #296: [ORC-391][c++] parseType does not accept underscore i...

Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/296#discussion_r206153654
  
    --- Diff: tools/test/TestCSVFileImport.cc ---
    @@ -53,3 +53,33 @@ TEST (TestCSVFileImport, test10rows) {
       EXPECT_EQ(expected, output);
       EXPECT_EQ("", error);
     }
    +
    +TEST (TestCSVFileImport, test10rows_underscore) {
    +  // create an ORC file from importing the CSV file
    +  const std::string pgm1 = findProgram("tools/src/csv-import");
    +  const std::string csvFile = findExample("TestCSVFileImport.test10rows.csv");
    +  const std::string orcFile = "/tmp/test_csv_import_test_10_rows.orc";
    +  const std::string schema = "struct<_a:bigint,b_:string,c:double>";
    --- End diff --
    
    Thanks for the test! can you rename `c` to `c_col`?


---