You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2018/07/27 19:12:17 UTC
[Impala-ASF-CR] IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11073
Change subject: IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
......................................................................
IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
Previously, Impala was only able to support DISTINCT in aggregate
functions over a single expr per SELECT list. IMPALA-110 removes this
restriction.
This patch eliminates code in query_generator.py that grouped exprs
for aggregate functions in order to pick a single to make DISTINCT,
and instead simply iterates over all agg functions and makes each one
DISTINCT with a configurable probability.
Testing:
- Ran the query generator overnight with no problems (except the usual
false positives).
Change-Id: I4a3f14655719ade7b2f6471c561dba4007fd46fa
---
M tests/comparison/query_generator.py
1 file changed, 10 insertions(+), 51 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/11073/1
--
To view, visit http://gerrit.cloudera.org:8080/11073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a3f14655719ade7b2f6471c561dba4007fd46fa
Gerrit-Change-Number: 11073
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11073 )
Change subject: IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/88/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/11073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a3f14655719ade7b2f6471c561dba4007fd46fa
Gerrit-Change-Number: 11073
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Jul 2018 19:44:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11073 )
Change subject: IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
......................................................................
IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
Previously, Impala was only able to support DISTINCT in aggregate
functions over a single expr per SELECT list. IMPALA-110 removes this
restriction.
This patch eliminates code in query_generator.py that grouped exprs
for aggregate functions in order to pick a single to make DISTINCT,
and instead simply iterates over all agg functions and makes each one
DISTINCT with a configurable probability.
Testing:
- Ran the query generator overnight with no problems (except the usual
false positives).
Change-Id: I4a3f14655719ade7b2f6471c561dba4007fd46fa
Reviewed-on: http://gerrit.cloudera.org:8080/11073
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/comparison/query_generator.py
1 file changed, 10 insertions(+), 51 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a3f14655719ade7b2f6471c561dba4007fd46fa
Gerrit-Change-Number: 11073
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11073 )
Change subject: IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3237/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a3f14655719ade7b2f6471c561dba4007fd46fa
Gerrit-Change-Number: 11073
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 27 Sep 2018 17:36:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11073 )
Change subject: IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-code-review-checks/88/
Running initial code review checks. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a3f14655719ade7b2f6471c561dba4007fd46fa
Gerrit-Change-Number: 11073
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Jul 2018 19:12:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11073 )
Change subject: IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
......................................................................
Patch Set 2: Code-Review+2
carrying forward
--
To view, visit http://gerrit.cloudera.org:8080/11073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a3f14655719ade7b2f6471c561dba4007fd46fa
Gerrit-Change-Number: 11073
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 27 Sep 2018 17:35:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11073 )
Change subject: IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a3f14655719ade7b2f6471c561dba4007fd46fa
Gerrit-Change-Number: 11073
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Sun, 29 Jul 2018 20:48:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11073 )
Change subject: IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a3f14655719ade7b2f6471c561dba4007fd46fa
Gerrit-Change-Number: 11073
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 27 Sep 2018 17:36:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11073 )
Change subject: IMPALA-110 (part 3): Add multiple DISTINCT support to query generator
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a3f14655719ade7b2f6471c561dba4007fd46fa
Gerrit-Change-Number: 11073
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 27 Sep 2018 21:23:50 +0000
Gerrit-HasComments: No