You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/31 03:52:29 UTC
[GitHub] [spark] yaooqinn opened a new pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
yaooqinn opened a new pull request #32010:
URL: https://github.com/apache/spark/pull/32010
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Using char and varchar with the string functions and some other expressions might be confusing and ambiguous. In this PR we add test cases for char and varchar with these operations to reveal these behavior and see if we can come up with a general pattern for them.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
test coverage
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
new tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810895659
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41338/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811808958
**[Test build #136794 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136794/testReport)** for PR 32010 at commit [`a5b9808`](https://github.com/apache/spark/commit/a5b9808eff6dded7fb2ec6032c9112d6272d5e3b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810991586
**[Test build #136755 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136755/testReport)** for PR 32010 at commit [`89990af`](https://github.com/apache/spark/commit/89990af1104e533f7b1ad720475036d8ce0f1865).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811458726
**[Test build #136777 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136777/testReport)** for PR 32010 at commit [`8b96ad8`](https://github.com/apache/spark/commit/8b96ad82d0f9c6ccefa988a92e67107dce6d35d7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811244157
**[Test build #136777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136777/testReport)** for PR 32010 at commit [`8b96ad8`](https://github.com/apache/spark/commit/8b96ad82d0f9c6ccefa988a92e67107dce6d35d7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811468114
**[Test build #136778 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136778/testReport)** for PR 32010 at commit [`6289d84`](https://github.com/apache/spark/commit/6289d84b147d39ac2043a3de048ea36b5928ce85).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811716911
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41377/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811287152
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41361/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810755134
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41329/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32010:
URL: https://github.com/apache/spark/pull/32010#discussion_r605378485
##########
File path: sql/core/src/test/resources/sql-tests/results/charvarchar.sql.out
##########
@@ -663,6 +663,478 @@ Location [not included in comparison]/{warehouse_dir}/char_part
Partition Provider Catalog
+-- !query
+create table str_tbl(c string, v string) using parquet
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+insert into str_tbl values
+ (null, null),
+ (null, 'S'),
+ ('N', 'N '),
+ ('Ne', 'Sp'),
+ ('Net ', 'Spa '),
+ ('NetE', 'Spar'),
+ ('NetEa ', 'Spark '),
+ ('NetEas ', 'Spark'),
+ ('NetEase', 'Spark-')
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+create table char_tbl4(c7 char(7), c8 char(8), v varchar(6), s string) using parquet
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+insert into char_tbl4 select c, c, v, c from str_tbl
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+select c7, c8, v, s from char_tbl4
+-- !query schema
+struct<c7:string,c8:string,v:string,s:string>
+-- !query output
+N N N N
+NULL NULL NULL NULL
Review comment:
OK, I noticed this too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32010:
URL: https://github.com/apache/spark/pull/32010#discussion_r605367754
##########
File path: sql/core/src/test/resources/sql-tests/inputs/charvarchar.sql
##########
@@ -61,7 +61,57 @@ desc formatted char_part;
MSCK REPAIR TABLE char_part;
desc formatted char_part;
+create table str_tbl(c string, v string) using parquet;
Review comment:
nit: this can be a temp view if it's only used to insert into `char_tbl4`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810755051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811485542
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136778/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811251485
**[Test build #136778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136778/testReport)** for PR 32010 at commit [`6289d84`](https://github.com/apache/spark/commit/6289d84b147d39ac2043a3de048ea36b5928ce85).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811282399
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41360/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811596632
cc @cloud-fan @HyukjinKwon thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811283940
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41361/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811658915
**[Test build #136794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136794/testReport)** for PR 32010 at commit [`a5b9808`](https://github.com/apache/spark/commit/a5b9808eff6dded7fb2ec6032c9112d6272d5e3b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811716911
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41377/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810998373
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136755/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810739013
**[Test build #136747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136747/testReport)** for PR 32010 at commit [`7d367e3`](https://github.com/apache/spark/commit/7d367e38e625a1007e1922ac3fb17da9d17647d6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #32010:
URL: https://github.com/apache/spark/pull/32010#discussion_r604675956
##########
File path: sql/core/src/test/resources/sql-tests/inputs/charvarchar.sql
##########
@@ -61,7 +61,60 @@ desc formatted char_part;
MSCK REPAIR TABLE char_part;
desc formatted char_part;
+create table char_tbl4(c char(5), v varchar(6)) using parquet;
Review comment:
We don't need tests for the mixed case of string types, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32010:
URL: https://github.com/apache/spark/pull/32010#discussion_r623887787
##########
File path: sql/core/src/test/resources/sql-tests/results/charvarchar.sql.out
##########
@@ -663,6 +663,478 @@ Location [not included in comparison]/{warehouse_dir}/char_part
Partition Provider Catalog
+-- !query
+create table str_tbl(c string, v string) using parquet
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+insert into str_tbl values
+ (null, null),
+ (null, 'S'),
+ ('N', 'N '),
+ ('Ne', 'Sp'),
+ ('Net ', 'Spa '),
+ ('NetE', 'Spar'),
+ ('NetEa ', 'Spark '),
+ ('NetEas ', 'Spark'),
+ ('NetEase', 'Spark-')
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+create table char_tbl4(c7 char(7), c8 char(8), v varchar(6), s string) using parquet
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+insert into char_tbl4 select c, c, v, c from str_tbl
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+select c7, c8, v, s from char_tbl4
+-- !query schema
+struct<c7:string,c8:string,v:string,s:string>
+-- !query output
+N N N N
+NULL NULL NULL NULL
Review comment:
it could be hacky to just fix the test side. I guess we should do this after the char could be a return type.
And this is not just a test fix but also a minor issue for the `spark-sql` shell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810820115
**[Test build #136755 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136755/testReport)** for PR 32010 at commit [`89990af`](https://github.com/apache/spark/commit/89990af1104e533f7b1ad720475036d8ce0f1865).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32010:
URL: https://github.com/apache/spark/pull/32010#discussion_r605368101
##########
File path: sql/core/src/test/resources/sql-tests/results/charvarchar.sql.out
##########
@@ -663,6 +663,478 @@ Location [not included in comparison]/{warehouse_dir}/char_part
Partition Provider Catalog
+-- !query
+create table str_tbl(c string, v string) using parquet
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+insert into str_tbl values
+ (null, null),
+ (null, 'S'),
+ ('N', 'N '),
+ ('Ne', 'Sp'),
+ ('Net ', 'Spa '),
+ ('NetE', 'Spar'),
+ ('NetEa ', 'Spark '),
+ ('NetEas ', 'Spark'),
+ ('NetEase', 'Spark-')
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+create table char_tbl4(c7 char(7), c8 char(8), v varchar(6), s string) using parquet
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+insert into char_tbl4 select c, c, v, c from str_tbl
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+select c7, c8, v, s from char_tbl4
+-- !query schema
+struct<c7:string,c8:string,v:string,s:string>
+-- !query output
+N N N N
+NULL NULL NULL NULL
Review comment:
The indentations do not match. We need to fix the test framework. @yaooqinn can you help with this later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810820115
**[Test build #136755 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136755/testReport)** for PR 32010 at commit [`89990af`](https://github.com/apache/spark/commit/89990af1104e533f7b1ad720475036d8ce0f1865).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810899541
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41338/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811658915
**[Test build #136794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136794/testReport)** for PR 32010 at commit [`a5b9808`](https://github.com/apache/spark/commit/a5b9808eff6dded7fb2ec6032c9112d6272d5e3b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811632116
The tests LGTM. To completely support the char feature, we may need to truly support it in the type system. For example, `upper(char_col)` should also return char type, not string type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810814434
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136747/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810739013
**[Test build #136747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136747/testReport)** for PR 32010 at commit [`7d367e3`](https://github.com/apache/spark/commit/7d367e38e625a1007e1922ac3fb17da9d17647d6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811287186
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41361/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811459883
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136777/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810814434
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136747/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811710229
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811459883
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136777/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811287186
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41361/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811251485
**[Test build #136778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136778/testReport)** for PR 32010 at commit [`6289d84`](https://github.com/apache/spark/commit/6289d84b147d39ac2043a3de048ea36b5928ce85).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811822937
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136794/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811276120
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41360/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810806977
**[Test build #136747 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136747/testReport)** for PR 32010 at commit [`7d367e3`](https://github.com/apache/spark/commit/7d367e38e625a1007e1922ac3fb17da9d17647d6).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811822937
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136794/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32010:
URL: https://github.com/apache/spark/pull/32010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811697938
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41377/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811485542
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136778/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811657957
> The tests LGTM. To completely support the char feature, we may need to truly support it in the type system. For example, `upper(char_col)` should also return char type, not string type.
the idea makes sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32010:
URL: https://github.com/apache/spark/pull/32010#discussion_r605006833
##########
File path: sql/core/src/test/resources/sql-tests/inputs/charvarchar.sql
##########
@@ -61,7 +61,60 @@ desc formatted char_part;
MSCK REPAIR TABLE char_part;
desc formatted char_part;
+create table char_tbl4(c char(5), v varchar(6)) using parquet;
Review comment:
yea, there are a lot of strange cases too :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32010:
URL: https://github.com/apache/spark/pull/32010#discussion_r605006833
##########
File path: sql/core/src/test/resources/sql-tests/inputs/charvarchar.sql
##########
@@ -61,7 +61,60 @@ desc formatted char_part;
MSCK REPAIR TABLE char_part;
desc formatted char_part;
+create table char_tbl4(c char(5), v varchar(6)) using parquet;
Review comment:
yea, there are a lot of strange cases too :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811282399
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41360/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811682724
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41377/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810899572
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41338/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810998373
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136755/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810899572
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41338/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-810755134
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41329/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32010: [SPARK-34908][SQL] Add test cases for char and varchar with functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32010:
URL: https://github.com/apache/spark/pull/32010#issuecomment-811244157
**[Test build #136777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136777/testReport)** for PR 32010 at commit [`8b96ad8`](https://github.com/apache/spark/commit/8b96ad82d0f9c6ccefa988a92e67107dce6d35d7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org