You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2018/11/01 15:58:53 UTC
hbase git commit: HBASE-19682 Use Collections.emptyList() For Empty
List Values
Repository: hbase
Updated Branches:
refs/heads/master 6bdaedd7c -> 21b98e107
HBASE-19682 Use Collections.emptyList() For Empty List Values
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/21b98e10
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/21b98e10
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/21b98e10
Branch: refs/heads/master
Commit: 21b98e107531a33c41c997340a8b1a95bd73d0d3
Parents: 6bdaedd
Author: Beluga Behr <da...@gmail.com>
Authored: Thu Oct 18 09:56:20 2018 -0400
Committer: Michael Stack <st...@apache.org>
Committed: Thu Nov 1 08:51:11 2018 -0700
----------------------------------------------------------------------
.../apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java | 3 ++-
.../org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java | 4 ++--
.../apache/hadoop/hbase/regionserver/StripeStoreFileManager.java | 4 +++-
.../src/main/java/org/apache/hadoop/hbase/util/FSUtils.java | 4 ++--
4 files changed, 9 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/21b98e10/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
index 3b945bd..aee9eeb 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
@@ -21,6 +21,7 @@ package org.apache.hadoop.hbase.master.balancer;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
+import java.util.Collections;
import java.util.Comparator;
import java.util.Deque;
import java.util.HashMap;
@@ -75,7 +76,7 @@ public abstract class BaseLoadBalancer implements LoadBalancer {
protected static final int MIN_SERVER_BALANCE = 2;
private volatile boolean stopped = false;
- private static final List<RegionInfo> EMPTY_REGION_LIST = new ArrayList<>(0);
+ private static final List<RegionInfo> EMPTY_REGION_LIST = Collections.emptyList();
static final Predicate<ServerMetrics> IDLE_SERVER_PREDICATOR
= load -> load.getRegionMetrics().isEmpty();
http://git-wip-us.apache.org/repos/asf/hbase/blob/21b98e10/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java
index da691b7..e33a9f2 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java
@@ -18,7 +18,7 @@
package org.apache.hadoop.hbase.regionserver;
import java.io.IOException;
-import java.util.ArrayList;
+import java.util.Collections;
import java.util.List;
import java.util.Locale;
import java.util.UUID;
@@ -57,7 +57,7 @@ implements RowProcessor<S,T> {
@Override
public List<UUID> getClusterIds() {
- return new ArrayList<>();
+ return Collections.emptyList();
}
@Override
http://git-wip-us.apache.org/repos/asf/hbase/blob/21b98e10/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFileManager.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFileManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFileManager.java
index 8caf013..ad40734 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFileManager.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFileManager.java
@@ -996,7 +996,9 @@ public class StripeStoreFileManager
@Override
public List<byte[]> getStripeBoundaries() {
- if (this.state.stripeFiles.isEmpty()) return new ArrayList<>();
+ if (this.state.stripeFiles.isEmpty()) {
+ return Collections.emptyList();
+ }
ArrayList<byte[]> result = new ArrayList<>(this.state.stripeEndRows.length + 2);
result.add(OPEN_KEY);
Collections.addAll(result, this.state.stripeEndRows);
http://git-wip-us.apache.org/repos/asf/hbase/blob/21b98e10/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
index 5b968db..85ed2ae 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
@@ -1034,7 +1034,7 @@ public abstract class FSUtils extends CommonFSUtils {
// assumes we are in a table dir.
List<FileStatus> rds = listStatusWithStatusFilter(fs, tableDir, new RegionDirFilter(fs));
if (rds == null) {
- return new ArrayList<>();
+ return Collections.emptyList();
}
List<Path> regionDirs = new ArrayList<>(rds.size());
for (FileStatus rdfs: rds) {
@@ -1101,7 +1101,7 @@ public abstract class FSUtils extends CommonFSUtils {
public static List<Path> getReferenceFilePaths(final FileSystem fs, final Path familyDir) throws IOException {
List<FileStatus> fds = listStatusWithStatusFilter(fs, familyDir, new ReferenceFileFilter(fs));
if (fds == null) {
- return new ArrayList<>();
+ return Collections.emptyList();
}
List<Path> referenceFiles = new ArrayList<>(fds.size());
for (FileStatus fdfs: fds) {