You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/04 05:51:45 UTC

[GitHub] [kafka] mjsax commented on pull request #10813: KAFKA-9559: Change default serde to be `null`

mjsax commented on pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#issuecomment-854379331


   How confident are we, that we covered most cases to avoid NPE and throw ConfigException? Seems it's still many places that we need to cover, and I am wondering if we follow the right approach?
   
   For example, instead of getting `keySerde` in some "outer layer" and forward a potential `null` that we check later, should we not pass around the `config` instead and call `defaultKeySerde` is we need it and let it through the ConfigException directly?
   
   Atm, the code seems rather scattered and it might be better to try to unify it more.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org