You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/08/05 20:08:37 UTC
[GitHub] [calcite] julianhyde opened a new pull request #2097: [CALCITE-4154] ProjectAggregateMergeRule and [CALCITE-3957] Merge SUM0 into COUNT
julianhyde opened a new pull request #2097:
URL: https://github.com/apache/calcite/pull/2097
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 commented on a change in pull request #2097: [CALCITE-4154] ProjectAggregateMergeRule and [CALCITE-3957] Merge SUM0 into COUNT
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #2097:
URL: https://github.com/apache/calcite/pull/2097#discussion_r466170917
##########
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##########
@@ -209,15 +202,11 @@ protected DiffRepository getDiffRepos() {
+ "where case when (sal = 1000) then\n"
+ "(case when sal = 1000 then null else 1 end is null) else\n"
+ "(case when sal = 2000 then null else 1 end is null) end is true";
- sql(sql).withPre(preProgram)
- .with(hepPlanner)
+ sql(sql).with(hepPlanner)
Review comment:
Can we also have `withRuleClass` or `withPreRuleClass` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] asfgit closed pull request #2097: [CALCITE-4154] ProjectAggregateMergeRule and [CALCITE-3957] Merge SUM0 into COUNT
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2097:
URL: https://github.com/apache/calcite/pull/2097
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] julianhyde commented on a change in pull request #2097: [CALCITE-4154] ProjectAggregateMergeRule and [CALCITE-3957] Merge SUM0 into COUNT
Posted by GitBox <gi...@apache.org>.
julianhyde commented on a change in pull request #2097:
URL: https://github.com/apache/calcite/pull/2097#discussion_r466536309
##########
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##########
@@ -209,15 +202,11 @@ protected DiffRepository getDiffRepos() {
+ "where case when (sal = 1000) then\n"
+ "(case when sal = 1000 then null else 1 end is null) else\n"
+ "(case when sal = 2000 then null else 1 end is null) end is true";
- sql(sql).withPre(preProgram)
- .with(hepPlanner)
+ sql(sql).with(hepPlanner)
Review comment:
I don't think so. I wanted to just cover the common case (simple programs with a few rules). For complex cases, people should continue to explicitly build programs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org