You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/14 15:27:46 UTC
[GitHub] [pulsar] RobertIndie opened a new pull request #12798: [Test] Fix flaky test in TransactionProduceTest::ackAbortTest
RobertIndie opened a new pull request #12798:
URL: https://github.com/apache/pulsar/pull/12798
### Motivation
The transaction timeout in `TransactionProduceTest::ackAbortTest` is too short, and if the test takes longer time, it will cause transaction to abort automatically and clear the pendingAcks, causing subsequent checks to fail.
```log
Error: ackAbortTest(org.apache.pulsar.broker.transaction.TransactionProduceTest) Time elapsed: 40.68 s <<< FAILURE!
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a lambda expression in org.apache.pulsar.broker.transaction.TransactionProduceTest expected [10] but found [0] within 10 seconds.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
```
### Modifications
Increase the timeout of the transaction in `TransactionProduceTest::ackAbortTest`.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Documentation
- [x] `no-need-doc`
This is just a fix for test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on pull request #12798: [Test] Fix flaky test in TransactionProduceTest::ackAbortTest
Posted by GitBox <gi...@apache.org>.
RobertIndie commented on pull request #12798:
URL: https://github.com/apache/pulsar/pull/12798#issuecomment-968405678
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #12798: [Test] Fix flaky test in TransactionProduceTest::ackAbortTest
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #12798:
URL: https://github.com/apache/pulsar/pull/12798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org