You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mgaido91 <gi...@git.apache.org> on 2018/08/02 10:33:50 UTC
[GitHub] spark pull request #21967: [SPARK-24598][DOCS] State in the documentation th...
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/21967
[SPARK-24598][DOCS] State in the documentation the behavior when arithmetic operations cause overflow
## What changes were proposed in this pull request?
According to the discussion in https://github.com/apache/spark/pull/21599, changing the behavior of arithmetic operations so that they can check for overflow is not nice in a minor release. What we can do for 2.4 is warn users about the current behavior in the documentation, so that they are aware of the issue and can take proper actions.
## How was this patch tested?
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgaido91/spark SPARK-24598_doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21967.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21967
----
commit 67e5f8dd6c9516c9199b35123d3cd87e2a4e3470
Author: Marco Gaido <ma...@...>
Date: 2018-08-02T10:30:51Z
[SPARK-24598][DOCS] State in the documentation the behavior when arithmetic operations cause overflow
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21967: [SPARK-24598][DOCS] State in the documentation the behav...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21967
**[Test build #93992 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93992/testReport)** for PR 21967 at commit [`67e5f8d`](https://github.com/apache/spark/commit/67e5f8dd6c9516c9199b35123d3cd87e2a4e3470).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21967: [SPARK-24598][DOCS] State in the documentation the behav...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21967
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1649/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21967: [SPARK-24598][DOCS] State in the documentation the behav...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21967
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93992/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21967: [SPARK-24598][DOCS] State in the documentation the behav...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21967
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21967: [SPARK-24598][DOCS] State in the documentation the behav...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21967
**[Test build #93992 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93992/testReport)** for PR 21967 at commit [`67e5f8d`](https://github.com/apache/spark/commit/67e5f8dd6c9516c9199b35123d3cd87e2a4e3470).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21967: [SPARK-24598][DOCS] State in the documentation the behav...
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21967
cc @cloud-fan
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21967: [SPARK-24598][DOCS] State in the documentation th...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21967
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21967: [SPARK-24598][DOCS] State in the documentation the behav...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21967
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21967: [SPARK-24598][DOCS] State in the documentation the behav...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21967
LGTM, cc @gatorsmile @hvanhovell @rxin
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org