You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/01 16:07:44 UTC
[GitHub] [incubator-tvm] electriclilies opened a new issue #6608: CHECK(data != nullptr) causes type checking to fail
electriclilies opened a new issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608
Many type relations check that types are not equal to nullptr. This results in early failure of the type checker. As an example, when trying to import efficientnet-b0 (tflite-int8-model), this error occurs:
`%0 = qnn.requantize(%images, 0.012566f, 131, 0.012566f, 3, out_dtype="int8") an internal invariant was violated while typechecking your program [17:21:40] /home/vega/github/incubator-tvm/src/relay/qnn/op/requantize.cc:261: Check failed: data != nullptr`
Instead of applying a check, the type relation should return false if data is equal to nullptr. This way, the type checker can continue to try to figure out what the type of data is. If the type checker really cannot find the type, the type checker itself should throw an error.
cc @jwfromm @areusch @vegaluisjose
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] electriclilies edited a comment on issue #6608: CHECK(data != nullptr) causes type checking to fail
Posted by GitBox <gi...@apache.org>.
electriclilies edited a comment on issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608#issuecomment-702267153
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] electriclilies edited a comment on issue #6608: CHECK(data != nullptr) causes type checking to fail
Posted by GitBox <gi...@apache.org>.
electriclilies edited a comment on issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608#issuecomment-702267153
These are the type relations I've found that have this issue, but I could be missing some.
- [x] ArgWhereRel
- [x] WhereRel
- [x] StridedSliceRel
- [x] SparseToDenseRel
- [x] NdarraySizeRel
- [x] MultiBoxTransformLocRel
- [ ] TupleGetItemRel
- [x] DequantizeRel
- [x] QuantizeRel
- [x] RequantizeRel
- [x] SimulatedQuantizeRel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] electriclilies edited a comment on issue #6608: CHECK(data != nullptr) causes type checking to fail
Posted by GitBox <gi...@apache.org>.
electriclilies edited a comment on issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608#issuecomment-702267153
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] electriclilies edited a comment on issue #6608: CHECK(data != nullptr) causes type checking to fail
Posted by GitBox <gi...@apache.org>.
electriclilies edited a comment on issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608#issuecomment-702267153
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] electriclilies edited a comment on issue #6608: CHECK(data != nullptr) causes type checking to fail
Posted by GitBox <gi...@apache.org>.
electriclilies edited a comment on issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608#issuecomment-702267153
These are the type relations I've found that have this issue, but I could be missing some.
- [x] ArgWhereRel
- [x] WhereRel
- [x] StridedSliceRel
- [x] SparseToDenseRel
- [ ] NdarraySizeRel
- [ ] MultiBoxTransformLocRel
- [ ] TupleGetItemRel
- [ ] DequantizeRel
- [ ] QuantizeRel
- [ ] RequantizeRel
- [x] SimulatedQuantizeRel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] electriclilies edited a comment on issue #6608: CHECK(data != nullptr) causes type checking to fail
Posted by GitBox <gi...@apache.org>.
electriclilies edited a comment on issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608#issuecomment-702267153
These are the type relations I've found that have this issue, but I could be missing some.
- [x] ArgWhereRel
- [ ] WhereRel
- [ ] StridedSliceRel
- [ ] SparseToDenseRel
- [ ] NdarraySizeRel
- [ ] MultiBoxTransformLocRel
- [ ] DequantizeRel
- [ ] QuantizeRel
- [ ] RequantizeRel
- [ ] SimulatedQuantizeRel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] electriclilies commented on issue #6608: CHECK(data != nullptr) causes type checking to fail
Posted by GitBox <gi...@apache.org>.
electriclilies commented on issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608#issuecomment-702267153
These are the type relations I've found that have this issue, but I could be missing some.
- [ ] ArgWhereRel
- [ ] WhereRel
- [ ] StridedSliceRel
- [ ] SparseToDenseRel
- [ ] NdarraySizeRel
- [ ] MultiBoxTransformLocRel
- [ ] DequantizeRel
- [ ] QuantizeRel
- [ ] RequantizeRel
- [ ] SimulatedQuantizeRel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] electriclilies edited a comment on issue #6608: CHECK(data != nullptr) causes type checking to fail
Posted by GitBox <gi...@apache.org>.
electriclilies edited a comment on issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608#issuecomment-702267153
These are the type relations I've found that have this issue, but I could be missing some.
- [x] ArgWhereRel
- [x] WhereRel
- [x] StridedSliceRel
- [x] SparseToDenseRel
- [ ] NdarraySizeRel
- [x] MultiBoxTransformLocRel
- [ ] TupleGetItemRel
- [ ] DequantizeRel
- [ ] QuantizeRel
- [ ] RequantizeRel
- [x] SimulatedQuantizeRel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] vegaluisjose commented on issue #6608: CHECK(data != nullptr) causes type checking to fail
Posted by GitBox <gi...@apache.org>.
vegaluisjose commented on issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608#issuecomment-702255315
@areusch that was actually the workaround. In other words, using the "onnx" version from this conversion does not seems to trigger the issue. However, I haven't tested the "correctness" of this onnx model, compared to the version provided in tensorflow hub.
The issue originally was found by using the TF-lite (8-bit) model directly. Specifically, this one:
https://tfhub.dev/tensorflow/lite-model/efficientnet/lite0/int8/2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] electriclilies edited a comment on issue #6608: CHECK(data != nullptr) causes type checking to fail
Posted by GitBox <gi...@apache.org>.
electriclilies edited a comment on issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608#issuecomment-702267153
These are the type relations I've found that have this issue, but I could be missing some.
- [x] ArgWhereRel
- [x] WhereRel
- [x] StridedSliceRel
- [x] SparseToDenseRel
- [x] NdarraySizeRel
- [x] MultiBoxTransformLocRel
- [ ] TupleGetItemRel
- [ ] DequantizeRel
- [ ] QuantizeRel
- [ ] RequantizeRel
- [x] SimulatedQuantizeRel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] areusch commented on issue #6608: CHECK(data != nullptr) causes type checking to fail
Posted by GitBox <gi...@apache.org>.
areusch commented on issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608#issuecomment-702248703
I think this was reproduced by trying to import the ONNX model generated by
```
python3 -m pip install geffnet
wget "https://github.com/rwightman/gen-efficientnet-pytorch/blob/master/onnx_export.py"
python3 onnx_export.py ./onnx_export/b4.onnx --model="tf_efficientnet_b4_ns" --img-size=380
```
from https://discuss.tvm.apache.org/t/unable-to-build-relay-function-twice/7987
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen closed issue #6608: CHECK(data != nullptr) causes type checking to fail
Posted by GitBox <gi...@apache.org>.
tqchen closed issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] electriclilies edited a comment on issue #6608: CHECK(data != nullptr) causes type checking to fail
Posted by GitBox <gi...@apache.org>.
electriclilies edited a comment on issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608#issuecomment-702267153
These are the type relations I've found that have this issue, but I could be missing some.
- [x] ArgWhereRel
- [x] WhereRel
- [x] StridedSliceRel
- [x] SparseToDenseRel
- [x] NdarraySizeRel
- [x] MultiBoxTransformLocRel
- [x] DequantizeRel
- [x] QuantizeRel
- [x] RequantizeRel
- [x] SimulatedQuantizeRel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] electriclilies edited a comment on issue #6608: CHECK(data != nullptr) causes type checking to fail
Posted by GitBox <gi...@apache.org>.
electriclilies edited a comment on issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608#issuecomment-702267153
These are the type relations I've found that have this issue, but I could be missing some.
- [x] ArgWhereRel
- [x] WhereRel
- [ ] StridedSliceRel
- [ ] SparseToDenseRel
- [ ] NdarraySizeRel
- [ ] MultiBoxTransformLocRel
- [ ] DequantizeRel
- [ ] QuantizeRel
- [ ] RequantizeRel
- [ ] SimulatedQuantizeRel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] areusch commented on issue #6608: CHECK(data != nullptr) causes type checking to fail
Posted by GitBox <gi...@apache.org>.
areusch commented on issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608#issuecomment-702257965
thanks for clarifying @vegaluisjose !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] electriclilies edited a comment on issue #6608: CHECK(data != nullptr) causes type checking to fail
Posted by GitBox <gi...@apache.org>.
electriclilies edited a comment on issue #6608:
URL: https://github.com/apache/incubator-tvm/issues/6608#issuecomment-702267153
These are the type relations I've found that have this issue, but I could be missing some.
- [x] ArgWhereRel
- [x] WhereRel
- [ ] StridedSliceRel
- [ ] SparseToDenseRel
- [ ] NdarraySizeRel
- [ ] MultiBoxTransformLocRel
- [ ] DequantizeRel
- [ ] QuantizeRel
- [ ] RequantizeRel
- [x] SimulatedQuantizeRel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org