[GitHub] [camel-kafka-connector] oscerd commented on a change in pull request #574: 573 allow to add remove elements from catalog dynamically through api

[GitBox <gi...@apache.org>]

oscerd commented on a change in pull request #574:
URL: https://github.com/apache/camel-kafka-connector/pull/574#discussion_r503310882



##########
File path: camel-kafka-connector-catalog/src/main/java/org/apache/camel/kafkaconnector/catalog/CamelKafkaConnectorCatalog.java
##########
@@ -83,7 +83,7 @@ private void initCatalog() {
         }
     }
 
-    public String getConnectorAsJson(String connectorName) {
+    private String loadConnectorAsJsonFromEmbeddedCatalog(String connectorName) {

Review comment:
       I wouldn't change this name. It doesn't add so much.

##########
File path: camel-kafka-connector-catalog/src/test/java/org/apache/camel/kafkaconnector/catalog/CamelKafkaConnectorCatalogTest.java
##########
@@ -20,30 +20,30 @@
 import java.util.Map;
 
 import org.apache.camel.kafkaconnector.model.CamelKafkaConnectorModel;
+import org.apache.camel.kafkaconnector.model.CamelKafkaConnectorOptionModel;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.*;

Review comment:
       Please don't import with * operator




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org