[GitHub] [pulsar] mipper commented on a change in pull request #11006: Update SQL config to use composed contaiiners

[GitBox <gi...@apache.org>]

mipper commented on a change in pull request #11006:
URL: https://github.com/apache/pulsar/pull/11006#discussion_r656167796



##########
File path: docker-compose/kitchen-sink/docker-compose.yml
##########
@@ -377,6 +377,9 @@ services:
       zookeeperServers: zk1:2181,zk2:2181,zk3:2181
       configurationStoreServers: zk1:2181,zk2:2181,zk3:2181
       pulsar.zookeeper-uri: zk1:2181,zk2:2181,zk3:2181
+      SQL_PREFIX_pulsar.broker-service-url: http://proxy1:8080

Review comment:
       But the setting still exists in the image.  Either it needs to be removed completely, or it needs to be updated to be valid in the given environment, no?  I have assumed it's left in there because it may still be used by something which is why it wasn't removed when it was replaced with the web- alternative.
   I'm happy to go either way - remove broker- completely, or keep it and make it correct for this environment.  It doesn't seem to make any sense to leave it and have it point to an invalid URL.  Which way should I go?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org