You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2019/08/09 12:25:38 UTC
[Impala-ASF-CR] IMPALA-8846: Undefined behaviour in RleEncoder::Put
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14042
Change subject: IMPALA-8846: Undefined behaviour in RleEncoder::Put
......................................................................
IMPALA-8846: Undefined behaviour in RleEncoder::Put
To test for overflow, we used 'repeat_count_ <=
std::numeric_limits<int32_t>::max()', but this is always true as
repeat_count_ is an int. This could have lead to undefined behaviour
because we increment repeat_count_ afterwards.
Changed the comparison not to allow equality.
Change-Id: I269443d1f1680e672fde7dd88eab5fcb56c65613
---
M be/src/util/rle-encoding.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/14042/1
--
To view, visit http://gerrit.cloudera.org:8080/14042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I269443d1f1680e672fde7dd88eab5fcb56c65613
Gerrit-Change-Number: 14042
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
[Impala-ASF-CR] IMPALA-8846: Undefined behaviour in RleEncoder::Put
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14042 )
Change subject: IMPALA-8846: Undefined behaviour in RleEncoder::Put
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4204/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I269443d1f1680e672fde7dd88eab5fcb56c65613
Gerrit-Change-Number: 14042
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Aug 2019 13:04:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8846: Undefined behaviour in RleEncoder::Put
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14042 )
Change subject: IMPALA-8846: Undefined behaviour in RleEncoder::Put
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4772/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I269443d1f1680e672fde7dd88eab5fcb56c65613
Gerrit-Change-Number: 14042
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Aug 2019 14:22:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8846: Undefined behaviour in RleEncoder::Put
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14042 )
Change subject: IMPALA-8846: Undefined behaviour in RleEncoder::Put
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I269443d1f1680e672fde7dd88eab5fcb56c65613
Gerrit-Change-Number: 14042
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Aug 2019 14:22:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8846: Undefined behaviour in RleEncoder::Put
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14042 )
Change subject: IMPALA-8846: Undefined behaviour in RleEncoder::Put
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I269443d1f1680e672fde7dd88eab5fcb56c65613
Gerrit-Change-Number: 14042
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Aug 2019 18:33:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8846: Undefined behaviour in RleEncoder::Put
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14042 )
Change subject: IMPALA-8846: Undefined behaviour in RleEncoder::Put
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I269443d1f1680e672fde7dd88eab5fcb56c65613
Gerrit-Change-Number: 14042
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Aug 2019 12:42:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8846: Undefined behaviour in RleEncoder::Put
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14042 )
Change subject: IMPALA-8846: Undefined behaviour in RleEncoder::Put
......................................................................
IMPALA-8846: Undefined behaviour in RleEncoder::Put
To test for overflow, we used 'repeat_count_ <=
std::numeric_limits<int32_t>::max()', but this is always true as
repeat_count_ is an int. This could have lead to undefined behaviour
because we increment repeat_count_ afterwards.
Changed the comparison not to allow equality.
Change-Id: I269443d1f1680e672fde7dd88eab5fcb56c65613
Reviewed-on: http://gerrit.cloudera.org:8080/14042
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/rle-encoding.h
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I269443d1f1680e672fde7dd88eab5fcb56c65613
Gerrit-Change-Number: 14042
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>