You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/09/20 16:33:00 UTC

[GitHub] [commons-beanutils] melloware opened a new pull request #40: Remove Commons Colletions Test Framework

melloware opened a new pull request #40:
URL: https://github.com/apache/commons-beanutils/pull/40


   Commons Collection Test Framework is 
   a) no longer supported
   b) has not been built since 2013
   c) doesn''t even have a pom in Maven Central its just a JAR.
   
   So BeanUtils should not be dependending on it. This PR removes that dependency and brings in the code necessary for the unit tets.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-beanutils] melloware commented on pull request #40: Remove Commons Collections Test Framework

Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #40:
URL: https://github.com/apache/commons-beanutils/pull/40#issuecomment-706221609


   Good idea all links updated to point to their original file in GitHub.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-beanutils] sebbASF commented on pull request #40: Remove Commons Collections Test Framework

Posted by GitBox <gi...@apache.org>.
sebbASF commented on pull request #40:
URL: https://github.com/apache/commons-beanutils/pull/40#issuecomment-706212702


   Thanks, but it would be better to link to the actual files please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-beanutils] sebbASF commented on pull request #40: Remove Commons Collections Test Framework

Posted by GitBox <gi...@apache.org>.
sebbASF commented on pull request #40:
URL: https://github.com/apache/commons-beanutils/pull/40#issuecomment-706153292


   It would be helpful to add a comment to the copied files pointing to the source of the copy.
   Now that we are using independent Git repos, it's not possible to track copies across Commons components.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-beanutils] sebbASF commented on pull request #40: Remove Commons Collections Test Framework

Posted by GitBox <gi...@apache.org>.
sebbASF commented on pull request #40:
URL: https://github.com/apache/commons-beanutils/pull/40#issuecomment-706153292


   It would be helpful to add a comment to the copied files pointing to the source of the copy.
   Now that we are using independent Git repos, it's not possible to track copies across Commons components.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-beanutils] melloware commented on pull request #40: Remove Commons Collections Test Framework

Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #40:
URL: https://github.com/apache/commons-beanutils/pull/40#issuecomment-706184351


   Added to each class header:
   ```java
    * <p>
    * Copied from Commons Collection 4.
    * @see <a href="https://github.com/apache/commons-collections">Commons Collections 4</a>
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-beanutils] garydgregory commented on pull request #40: Remove Commons Collections Test Framework

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #40:
URL: https://github.com/apache/commons-beanutils/pull/40#issuecomment-892045393


   I'll try and take a look this week...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org