You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/20 23:14:26 UTC
[jira] [Commented] (CAMEL-9210) Make credentials optional in AWS
component. Use instance profile if not supplied.
[ https://issues.apache.org/jira/browse/CAMEL-9210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832591#comment-15832591 ]
ASF GitHub Bot commented on CAMEL-9210:
---------------------------------------
GitHub user onders86 opened a pull request:
https://github.com/apache/camel/pull/1415
CAMEL-9210 accessKey and secretKey are optional
these options are optional now, if not provided, AWS SDK handles them
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/onders86/camel CAMEL-9210
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1415.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1415
----
commit b1cfdef300ccb5cc41e19d878979dad579e1f37c
Author: onders86 <on...@gmail.com>
Date: 2017-01-20T16:42:26Z
CAMEL-9210 - accessKey and secretKey options for CloudWatch is now optional
accessKey and secretKey options for CloudWatch is now optional
and AWS Java SDK handles those keys unless they are not provided in URI.
commit b012c06a05997348712fda0cf2c4a057fbd25439
Author: onders86 <on...@gmail.com>
Date: 2017-01-21T00:16:06Z
CAMEL-9210 - csfix -> accessKey and secretKey options for CloudWatch is now optional
csfix -> accessKey and secretKey options for CloudWatch is now optional
and AWS Java SDK handles those keys unless they are not provided in URI.
commit 60a727687dc0f2bdcbd30260bb562f1d7bdfd6f3
Author: onders86 <on...@gmail.com>
Date: 2017-01-21T00:18:12Z
CAMEL-9210 - accessKey and secretKey options are optional
accessKey and secretKey options are optional now
----
> Make credentials optional in AWS component. Use instance profile if not supplied.
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-9210
> URL: https://issues.apache.org/jira/browse/CAMEL-9210
> Project: Camel
> Issue Type: Improvement
> Components: camel-aws
> Affects Versions: 2.16.0
> Reporter: Ben Parry
> Assignee: onder sezgin
> Priority: Minor
> Fix For: Future
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> AWS supports instance profiles so users don't need to manage credentials on individual instances.
> Please update the AWS connector so that the access key and secret are optional, and if not given try to use those provided by an instance profile attached to the instance if one exists. Most AWS SDKs support this, so it should just be a matter of updating the AWS SDK and making those two parameters optional.
> As a bonus, it'd be great for development if it also looked in environment variables for the token and secret as well. That way users of the AWS connector could choose not to pass the token & secret, but if they exported them into their environment they would be picked up. This would allow local development on a non-EC2 instance (i.e. an instance without an instance profile attached).
> So, the order of resolution would be:
> 1. If key & token are provided to the AWS connector, use them (current behaviour).
> 2. If not, try to pull out AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY from environment variables, and use those. If not present, expect the AWS SDK to look into an instance profile associated with the instance for credentials.
> See https://github.com/aws/aws-cli for an example implementation with python/boto. The suggestion above mirrors the approach they take.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)