You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/12/31 04:12:11 UTC

[GitHub] EronWright opened a new pull request #7386: [FLINK-11234][table][tests] fix ExternalTableCatalogBuilder::supportsBatch

EronWright opened a new pull request #7386: [FLINK-11234][table][tests] fix ExternalTableCatalogBuilder::supportsBatch
URL: https://github.com/apache/flink/pull/7386
 
 
   Signed-off-by: EronWright <er...@gmail.com>
   
   ## What is the purpose of the change
   Fix the `ExternalTableCatalogBuilder` to be able to produce batch-only tables, and test this more thoroughly by correctly labeling the tables produced by `CommonTestData`.
   
   ## Brief change log
   - fix the logic in supportsBatch to properly declare a batch-only table
   - adjust CommonTestData to provide batch-only or streaming-only tables
   
   ## Verifying this change
   This change is already covered by existing tests, such as `ExternalCatalogTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? N/A
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services