You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "dheeraj12347 (via GitHub)" <gi...@apache.org> on 2026/10/03 13:56:32 UTC
[PR] Fix non-interactive template uploads [cloudstack-cloudmonkey]
dheeraj12347 opened a new pull request, #228:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/228
## Summary
Fixes #227.
Template uploads using `filepath=` failed in non-interactive mode because
`UploadFiles()` unconditionally used the CLI spinner.
`StartSpinner()` returns nil when CloudMonkey is running without a shell,
which caused a nil pointer dereference when the spinner was accessed.
This change:
- only creates the spinner when running interactively
- guards spinner operations when no spinner is available
- allows file uploads to continue normally in non-interactive mode
- adds a regression test that performs an actual multipart upload with
`HasShell=false`
## Validation
- `go test ./...` ✅
- `go vet ./...` ✅
- `git diff --check` ✅
- Regression test for non-interactive upload ✅
Fixes #227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix non-interactive template uploads [cloudstack-cloudmonkey]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #228:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/228#issuecomment-5990349522
<!-- cmk-build-artifact-comment -->
✅ Build complete for PR #228.
📦 Binary artifacts are available in the [workflow run](https://github.com/apache/cloudstack-cloudmonkey/actions/runs/37127903227) (expires on October 15, 2026).
> **Note:** Download artifacts by clicking on the workflow run link above, then scroll to the "Artifacts" section.
> _Artifacts from PR builds are for testing only and may contain unreviewed, malicious code._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix non-interactive template uploads [cloudstack-cloudmonkey]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #228:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/228#issuecomment-6124655387
🤦 , didn't check for smoke tests
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix non-interactive template uploads [cloudstack-cloudmonkey]
Posted by "dheeraj12347 (via GitHub)" <gi...@apache.org>.
dheeraj12347 commented on PR #228:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/228#issuecomment-5969879089
Hi @jl0815, @DaanHoogland I’ve opened PR #228 for #227. I traced the non-interactive template upload crash to UploadFiles() dereferencing a nil spinner when HasShell=false. The fix makes spinner handling optional while preserving interactive progress behavior, and I added a regression test that performs an actual multipart upload in non-interactive mode. go test ./..., go vet ./..., and git diff --check all pass. Would appreciate your review when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix non-interactive template uploads [cloudstack-cloudmonkey]
Posted by "jl0815 (via GitHub)" <gi...@apache.org>.
jl0815 commented on PR #228:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/228#issuecomment-6039716670
@dheeraj12347 Thank you for fixing it so quickly. I can confirm that the upload now works in both interactive and script modes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix non-interactive template uploads [cloudstack-cloudmonkey]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #228:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org