[GitHub] [bookkeeper] fpj commented on a change in pull request #2542: Check np for LifecycleComponent close

[GitBox <gi...@apache.org>]

fpj commented on a change in pull request #2542:
URL: https://github.com/apache/bookkeeper/pull/2542#discussion_r560054691



##########
File path: stream/server/src/main/java/org/apache/bookkeeper/stream/server/service/RegistrationStateService.java
##########
@@ -95,6 +95,10 @@ protected void doStart() {
 
     @Override
     protected void doStop() {
+        if (null == stateManager) {
+            log.warn("State Manager is null, no need to stop it.");

Review comment:
       A warn message for me indicates a potential action from the user. In this case, it is just information that the state manager is null, so no action is required, correct? If so, then it is an info message at best, if not debug.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org