[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a change in pull request #76: SLING-10359 : RepPrincipalPolicyEntryHandler: rep:effectivePath is defined to be of type PATH

[GitBox <gi...@apache.org>]

kwin commented on a change in pull request #76:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/76#discussion_r628143822



##########
File path: src/main/java/org/apache/sling/feature/cpconverter/handlers/RepPrincipalPolicyEntryHandler.java
##########
@@ -78,7 +79,7 @@ public void startElement(String uri, String localName, String qName, Attributes
                         throw new IllegalStateException("isolated principal-based access control entry. no principal found.");
                     }
                     List<String> privileges = extractValues(attributes.getValue(REP_PRIVILEGES));
-                    RepoPath effectivePath = new RepoPath(attributes.getValue(REP_EFFECTIVE_PATH));
+                    RepoPath effectivePath = new RepoPath(extractEffectivePath(attributes.getValue(REP_EFFECTIVE_PATH)));

Review comment:
       You can use https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/e53fdfaa10cab40aea5d6d4adcb06a7ea79862cc/src/main/java/org/apache/sling/feature/cpconverter/vltpkg/ValueConverter.java#L60 instead




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org