[GitHub] [druid] clintropolis commented on a diff in pull request #13779: fix filtering nested field virtual column when used with non nested column input

["clintropolis (via GitHub)" <gi...@apache.org>]

clintropolis commented on code in PR #13779:
URL: https://github.com/apache/druid/pull/13779#discussion_r1100962754


##########
processing/src/main/java/org/apache/druid/segment/virtual/NestedFieldVirtualColumn.java:
##########
@@ -647,7 +650,10 @@ public ColumnCapabilities capabilities(ColumnInspector inspector, String columnN
     final ColumnCapabilities capabilities = inspector.getColumnCapabilities(this.columnName);
 
     if (capabilities != null) {
-      if (!capabilities.isPrimitive() && capabilities.isDictionaryEncoded().isTrue()) {
+      // if the underlying column is a nested column (and persisted to disk, re: the dictionary encoded check)

Review Comment:
   yeah, im certain there is a cooler way to do this, especially when the underlying inspector is the segment, but i'll save that for another day



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org