You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2018/06/15 00:53:52 UTC

[4/5] impala git commit: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"

IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"

In this case, the query is failing. It happens to use the cancellation
path to cleanup, but from a user's perspective this is a query failure
not a cancellation. Reword the message to reflect that.

Change-Id: I4d8e755aef196e5c25205094af9c8486eb899344
Reviewed-on: http://gerrit.cloudera.org:8080/10717
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/76f8ff4a
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/76f8ff4a
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/76f8ff4a

Branch: refs/heads/master
Commit: 76f8ff4a1507c3a7f86eb58dbac191024b59890e
Parents: 527c0ca
Author: Dan Hecht <dh...@cloudera.com>
Authored: Thu Jun 14 13:05:49 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Fri Jun 15 00:00:58 2018 +0000

----------------------------------------------------------------------
 be/src/service/impala-server.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/76f8ff4a/be/src/service/impala-server.cc
----------------------------------------------------------------------
diff --git a/be/src/service/impala-server.cc b/be/src/service/impala-server.cc
index c08241e..d70b5d9 100644
--- a/be/src/service/impala-server.cc
+++ b/be/src/service/impala-server.cc
@@ -1694,7 +1694,7 @@ void ImpalaServer::MembershipCallback(
           cancellation_entry != queries_to_cancel.end();
           ++cancellation_entry) {
         stringstream cause_msg;
-        cause_msg << "Cancelled due to unreachable impalad(s): ";
+        cause_msg << "Failed due to unreachable impalad(s): ";
         for (int i = 0; i < cancellation_entry->second.size(); ++i) {
           cause_msg << TNetworkAddressToString(cancellation_entry->second[i]);
           if (i + 1 != cancellation_entry->second.size()) cause_msg << ", ";