You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/08/03 21:43:14 UTC
[jira] Created: (CASSANDRA-337) Make BinaryMemtable work
Make BinaryMemtable work
------------------------
Key: CASSANDRA-337
URL: https://issues.apache.org/jira/browse/CASSANDRA-337
Project: Cassandra
Issue Type: Bug
Components: Core
Reporter: Jonathan Ellis
Fix For: 0.4
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741987#action_12741987 ]
Chris Goffinet commented on CASSANDRA-337:
------------------------------------------
-1
This should be reverted. As my discussion with Jonathan, we want to make the Binary Memtable Flusher thread configurable, and we wouldn't want to have it under the same path as cfStore, since that should be a different tunable. I'll have my patches ready later this week for Binary Memtable work we have done at Digg.
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748581#action_12748581 ]
Jonathan Ellis commented on CASSANDRA-337:
------------------------------------------
> I want the ability to specify a min and max for the threads in storage-conf.xml
works for me.
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Working-version-of-BMT.patch, 0002-Added-flushAndshutdown-v2.patch, 0003-Removed-decorateKey-in-writer.append-in-BMT.patch, 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742333#action_12742333 ]
Hudson commented on CASSANDRA-337:
----------------------------------
Integrated in Cassandra #165 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/165/])
use CFS executor for BMt flushes.
patch by jbellis; reviewed by Eric Evans for
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-337:
-------------------------------------
Attachment: 0001-Refactored-and-merged-BMT-to-MT-codepath-v3.patch
Refactored, and merged BMT to MT codepath. Added FlushMinThreads and FlushMaxThreads.
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Refactored-and-merged-BMT-to-MT-codepath-v3.patch, 0001-Working-version-of-BMT.patch, 0002-Added-flushAndshutdown-v2.patch, 0003-Removed-decorateKey-in-writer.append-in-BMT.patch, 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741968#action_12741968 ]
Jonathan Ellis commented on CASSANDRA-337:
------------------------------------------
BinaryMemtable is intended to allow writing pre-serialized data, but FB never really cleaned it up to make it useful for anyone but them. Chris has done that and this ticket is to remind him to post diffs.
My patch just removes an unnecessary extra executor and class and has BMt use the CFS executor for flushes like normal Mt.
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748578#action_12748578 ]
Chris Goffinet commented on CASSANDRA-337:
------------------------------------------
I can live with merging the executors for BMT flush and normal MT. Though I want the ability to specify a min and max for the threads in storage-conf.xml. During an import, we would want the ability to have a certain quality of service (I want a min of 4 threads during normal usage, but when we start binary import, I want a higher thread count).
Merging both executors makes it a little harder, but the benefit is less code/cruft to manage -- that's a win for sure. When we were benchmarking our 7 node cluster with 600-800Mb/s per node we saw lower memory usage/better throughput on the flushing by having 2 threads per disk.
If this is acceptable (above) I can submit a patch.
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Working-version-of-BMT.patch, 0002-Added-flushAndshutdown-v2.patch, 0003-Removed-decorateKey-in-writer.append-in-BMT.patch, 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741949#action_12741949 ]
Eric Evans commented on CASSANDRA-337:
--------------------------------------
+1
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747642#action_12747642 ]
Jonathan Ellis commented on CASSANDRA-337:
------------------------------------------
is there overlap b/t this and CASSANDRA-342?
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Working-version-of-BMT.patch, 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741970#action_12741970 ]
Jonathan Ellis commented on CASSANDRA-337:
------------------------------------------
committed the CFS patch.
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741962#action_12741962 ]
Michael Greene commented on CASSANDRA-337:
------------------------------------------
I don't understand the scope of this issue and the submitted patches. Can anyone elaborate?
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-337:
-------------------------------------
Attachment: 0002-Added-flushAndshutdown-v2.patch
Fixed, forgot the getConnections
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Working-version-of-BMT.patch, 0002-Added-flushAndshutdown-v2.patch, 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-337:
-------------------------------------
Attachment: 337.patch
my humble contribution to the cleanup: use CFS executor for BMt flushes
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747212#action_12747212 ]
Chris Goffinet commented on CASSANDRA-337:
------------------------------------------
Example of using BMT:
http://github.com/lenn0x/Cassandra-Hadoop-BMT/tree/master
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Working-version-of-BMT.patch, 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-337:
----------------------------------------
Assignee: Chris Goffinet
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748551#action_12748551 ]
Jonathan Ellis commented on CASSANDRA-337:
------------------------------------------
I still don't see any reason to use separate executors for BMT flush and normal MT. In fact I was thinking normal MT should probably have threads = #disks. (Why do you use 2x?) I'd favor keeping a single executor, with configurable thread count.
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Working-version-of-BMT.patch, 0002-Added-flushAndshutdown-v2.patch, 0003-Removed-decorateKey-in-writer.append-in-BMT.patch, 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-337:
-------------------------------------
Attachment: 0002-Added-flushAndShutdown.patch
Forgot to add the flushAndShutdown method
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Working-version-of-BMT.patch, 0002-Added-flushAndShutdown.patch, 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747948#action_12747948 ]
Johan Oskarsson commented on CASSANDRA-337:
-------------------------------------------
I assume the two last patches are to be applied together? If I try to build trunk + those patches I get the following error:
[javac] /home/cassandra/cassandra-trunk/src/java/org/apache/cassandra/net/MessagingService.java:505: cannot find symbol
[javac] symbol : method getConnections()
[javac] location: class org.apache.cassandra.net.TcpConnectionManager
[javac] for(TcpConnection connection: entry.getValue().getConnections())
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Working-version-of-BMT.patch, 0002-Added-flushAndShutdown.patch, 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-337:
-------------------------------------
Attachment: 337-v3.patch
looking good. here is my version with light cleanup done.
but I don't see a way to check if a flushandshutdown is complete, and it's safe to kill the node?
should we make logger_.debug("Shutdown invocation complete.");
run at info level instead of debug? or something more sophisticated?
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Refactored-and-merged-BMT-to-MT-codepath-v3.patch, 0001-Working-version-of-BMT.patch, 0002-Added-flushAndshutdown-v2.patch, 0003-Removed-decorateKey-in-writer.append-in-BMT.patch, 337-rebased.patch, 337-v3.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-337:
-------------------------------------
Attachment: 337-rebased.patch
rebased
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-337:
-------------------------------------
Attachment: 0001-Working-version-of-BMT.patch
Working version of BMT that we are running at Digg. Hopefully I didn't miss anything. Wanted to post this before I forget about it :)
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Working-version-of-BMT.patch, 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-337.
--------------------------------------
Resolution: Fixed
committed v3 w/ the log info change.
do you want to submit the demo from github for contrib/ in another ticket?
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Refactored-and-merged-BMT-to-MT-codepath-v3.patch, 0001-Working-version-of-BMT.patch, 0002-Added-flushAndshutdown-v2.patch, 0003-Removed-decorateKey-in-writer.append-in-BMT.patch, 337-rebased.patch, 337-v3.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748895#action_12748895 ]
Chris Goffinet commented on CASSANDRA-337:
------------------------------------------
Sure thing. See CASSANDRA-398
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Refactored-and-merged-BMT-to-MT-codepath-v3.patch, 0001-Working-version-of-BMT.patch, 0002-Added-flushAndshutdown-v2.patch, 0003-Removed-decorateKey-in-writer.append-in-BMT.patch, 337-rebased.patch, 337-v3.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-337:
-------------------------------------
Attachment: 0003-Removed-decorateKey-in-writer.append-in-BMT.patch
Removed decorateKey() in writer.append
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Working-version-of-BMT.patch, 0002-Added-flushAndshutdown-v2.patch, 0003-Removed-decorateKey-in-writer.append-in-BMT.patch, 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747713#action_12747713 ]
Chris Goffinet commented on CASSANDRA-337:
------------------------------------------
Looking at his code, no. I made some minor interface changes such as flushBinary() public but everything I have done affects the BMT work already there. He seems to be adding functionality, I have no Hadoop code in my BMT.
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Working-version-of-BMT.patch, 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747783#action_12747783 ]
Jeff Hodges commented on CASSANDRA-337:
---------------------------------------
Yeah, this looks to be clear of any interaction with CASSANDRA-342.
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Working-version-of-BMT.patch, 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-337:
-------------------------------------
Attachment: (was: 0002-Added-flushAndShutdown.patch)
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Working-version-of-BMT.patch, 0002-Added-flushAndshutdown-v2.patch, 337-rebased.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749118#action_12749118 ]
Hudson commented on CASSANDRA-337:
----------------------------------
Integrated in Cassandra #181 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/181/])
Fixes to make BinaryMemtable useful. Highlights are configurable threads for [binary]memtable flushing and flushAndShutdown JMX/nodeprobe directive.
patch by Chris Goffinet; reviewed by jbellis for
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Refactored-and-merged-BMT-to-MT-codepath-v3.patch, 0001-Working-version-of-BMT.patch, 0002-Added-flushAndshutdown-v2.patch, 0003-Removed-decorateKey-in-writer.append-in-BMT.patch, 337-rebased.patch, 337-v3.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-337) Make BinaryMemtable work
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748871#action_12748871 ]
Chris Goffinet commented on CASSANDRA-337:
------------------------------------------
I think going to logger_.info would be fine. Me and Sammy plan on opening another ticket for better shutdown support in Cassandra. We could get more sophisticated there.
> Make BinaryMemtable work
> ------------------------
>
> Key: CASSANDRA-337
> URL: https://issues.apache.org/jira/browse/CASSANDRA-337
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Chris Goffinet
> Fix For: 0.4
>
> Attachments: 0001-Refactored-and-merged-BMT-to-MT-codepath-v3.patch, 0001-Working-version-of-BMT.patch, 0002-Added-flushAndshutdown-v2.patch, 0003-Removed-decorateKey-in-writer.append-in-BMT.patch, 337-rebased.patch, 337-v3.patch, 337.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.