[jira] Commented: (SYNAPSE-574) Added a new attribute letting DBReport mediator to use in a distributed tx together with tx mediator

["Ruwan Linton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SYNAPSE-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758971#action_12758971 ] 

Ruwan Linton commented on SYNAPSE-574:
--------------------------------------

Rajika, few comments on the patch...

This attribute has not been used in the DBLookup and only used in the DBReport mediator, so why is the attribute defined in the AbstractDBMediator. To me it should go to the DBReportMediator, if not there is something missing in the patch.

Secondly, it is a boolean value but you have used it as a String filed, it is much faster to check the boolean value over the String#equals function to check the value is true or not. When ever it is possible to use a boolean we should use that over Strings, so do not use String fields to represent boolean values in Java.

Also when you do a change to the configuration that has to be reflected in the Factory/Serializer header comments which has the configuration of that particular mediator, and also in the Synapse_Configuration_Language.xml file which is a docx used to generate the Synapse Configuration Language documentation.

Thanks,
Ruwan 

> Added a new attribute letting DBReport mediator to use in a distributed tx together with tx mediator
> ----------------------------------------------------------------------------------------------------
>
>                 Key: SYNAPSE-574
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-574
>             Project: Synapse
>          Issue Type: Bug
>            Reporter: Rajika Kumarasiri
>            Assignee: Ruwan Linton
>         Attachments: SYNAPSE-574.patch
>
>
> With this patch we can specify the optional attribute "useTransaction=true|false" in DBReport mediator which will let us use the DBReport mediator in a distributed tx together with tx mediator. 
> <dbreport useTransaction="true|false">
> ....
> </dbreport>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org