[jira] [Comment Edited] (CALCITE-1833) User-defined aggregate functions with more than one parameter

["yuemeng (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076007#comment-16076007 ] 

yuemeng edited comment on CALCITE-1833 at 7/6/17 6:27 AM:
----------------------------------------------------------

[~julianhyde]
Firstly,thanks a lot for your review.
since ,our project based on the latest release version 1.12.0,I fixed this bug based on that version,the master can solve this bug use the same way
you can put yuemeng on the commit.
thanks for your review and advise


was (Author: yuemeng):
[~julianhyde]
Fristly,thanks a lot for your review.
since ,our project based on the latest release version 1.12.0,I fixed this bug based on that version,the master can solve this bug use the same way
you can put yuemeng on the commit.
thanks for your review and advise

> User-defined aggregate functions with more than one parameter
> -------------------------------------------------------------
>
>                 Key: CALCITE-1833
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1833
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.12.0
>            Reporter: yuemeng
>            Assignee: yuemeng
>            Priority: Blocker
>         Attachments: 0001-CALCITE-1833-User-defined-aggregate-functions-with-m.patch
>
>
> Currently user-defined aggregate functions must have one parameter.
> SqlAggFunction need new constructor to set paramTypes to allow user-defined aggregate function to have more than one parameter.
> If a class(A) implement interface of AggregateFunction,that instance of class will be transformed to instance of  SqlUserDefinedAggFunction by call toOp method in CalciteCatalogReader.
> when construct the SqlUserDefinedAggFunction  instance will set paramTypes to null for super class sqlFunction indirectly.
> The problem is:
> we will  get SqlUserDefinedAggFunction paramTypes to sql validatefilte,but it will be filter nothing 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)