You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/07 23:05:57 UTC
[GitHub] [airflow] potiuk opened a new issue, #28789: Add colors in help outputs of Airfow CLI commands
potiuk opened a new issue, #28789:
URL: https://github.com/apache/airflow/issues/28789
### Body
Folowing up after https://github.com/apache/airflow/pull/22613#issuecomment-1374530689 - seems that there is a new rich-argparse project that might give us the option without rewriting Airflow's argument parsing to click (click has a number of possible performance issues that might impact airlfow's speed of CLI command parsing)
Seems this might be rather easy thing to do (just adding the formatter class for argparse).
Would be nice if someone implements it and tests (also for performance of CLI).
### Committer
- [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on issue #28789: Add colors in help outputs of Airfow CLI commands
Posted by GitBox <gi...@apache.org>.
Bowrna commented on issue #28789:
URL: https://github.com/apache/airflow/issues/28789#issuecomment-1379826391
@potiuk Do you mean that it should be done either for all the CLI commands or for nothing? Am i right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #28789: Add colors in help outputs of Airfow CLI commands
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #28789:
URL: https://github.com/apache/airflow/issues/28789#issuecomment-1380329423
I believe so. This is what rich-argparse promises at least. Change formatter and all your commands will get colour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #28789: Add colors in help outputs of Airfow CLI commands
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #28789:
URL: https://github.com/apache/airflow/issues/28789#issuecomment-1374901005
Sure. But I guess it will be "all-or-nothing"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #28789: Add colors in help outputs of Airfow CLI commands
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #28789: Add colors in help outputs of Airfow CLI commands
URL: https://github.com/apache/airflow/issues/28789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on issue #28789: Add colors in help outputs of Airfow CLI commands
Posted by GitBox <gi...@apache.org>.
Bowrna commented on issue #28789:
URL: https://github.com/apache/airflow/issues/28789#issuecomment-1374697819
@potiuk Could I try my hands on a few CLI commands to use rich-argparse?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] loulsb commented on issue #28789: Add colors in help outputs of Airfow CLI commands
Posted by "loulsb (via GitHub)" <gi...@apache.org>.
loulsb commented on issue #28789:
URL: https://github.com/apache/airflow/issues/28789#issuecomment-1400882791
@potiuk I would like to work on this. Any advice on where to start?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #28789: Add colors in help outputs of Airfow CLI commands
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #28789:
URL: https://github.com/apache/airflow/issues/28789#issuecomment-1400963065
Just here and see if you can apply it to all argparse https://github.com/hamdanal/rich-argparse
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org