You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Jakob Homan (JIRA)" <ji...@apache.org> on 2008/07/08 00:12:31 UTC
[jira] Created: (ZOOKEEPER-68) parseACLs in ZooKeeper.java fails to
parse elements of ACL, should be lastIndexOf rather than IndexOf
parseACLs in ZooKeeper.java fails to parse elements of ACL, should be lastIndexOf rather than IndexOf
-----------------------------------------------------------------------------------------------------
Key: ZOOKEEPER-68
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-68
Project: Zookeeper
Issue Type: Bug
Components: java client
Reporter: Jakob Homan
Priority: Minor
the parseACLs(String aclString) method attempts to prase ACLs from the form of scheme:id:perm into the three components, delineated by the colons. The current version calls indexOf for both the first and second colon, receiving the same value for both and failing as if there were only one colon in the string. I created a one-line patch to call lastIndexOf for the second colon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-68) parseACLs in ZooKeeper.java fails to
parse elements of ACL, should be lastIndexOf rather than IndexOf
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-68:
-----------------------------------
Attachment: ZOOKEEPER-68_1.patch
the patch seems fine but not generated from the trunk. you should do an svn diff from the top level directory. I created a patch thats from the trunk and uploaded it.
> parseACLs in ZooKeeper.java fails to parse elements of ACL, should be lastIndexOf rather than IndexOf
> -----------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-68
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-68
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
> Reporter: Jakob Homan
> Priority: Minor
> Attachments: colonindices.diff, ZOOKEEPER-68_1.patch
>
>
> the parseACLs(String aclString) method attempts to prase ACLs from the form of scheme:id:perm into the three components, delineated by the colons. The current version calls indexOf for both the first and second colon, receiving the same value for both and failing as if there were only one colon in the string. I created a one-line patch to call lastIndexOf for the second colon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-68) parseACLs in ZooKeeper.java fails to
parse elements of ACL, should be lastIndexOf rather than IndexOf
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-68:
---------------------------------
Status: Patch Available (was: Open)
Changes second call to indexOf to lastIndexOf
> parseACLs in ZooKeeper.java fails to parse elements of ACL, should be lastIndexOf rather than IndexOf
> -----------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-68
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-68
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
> Reporter: Jakob Homan
> Priority: Minor
>
> the parseACLs(String aclString) method attempts to prase ACLs from the form of scheme:id:perm into the three components, delineated by the colons. The current version calls indexOf for both the first and second colon, receiving the same value for both and failing as if there were only one colon in the string. I created a one-line patch to call lastIndexOf for the second colon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-68) parseACLs in ZooKeeper.java fails to
parse elements of ACL, should be lastIndexOf rather than IndexOf
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-68:
-----------------------------------
Hadoop Flags: [Reviewed]
> parseACLs in ZooKeeper.java fails to parse elements of ACL, should be lastIndexOf rather than IndexOf
> -----------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-68
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-68
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
> Reporter: Jakob Homan
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: colonindices.diff, ZOOKEEPER-68_1.patch
>
>
> the parseACLs(String aclString) method attempts to prase ACLs from the form of scheme:id:perm into the three components, delineated by the colons. The current version calls indexOf for both the first and second colon, receiving the same value for both and failing as if there were only one colon in the string. I created a one-line patch to call lastIndexOf for the second colon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-68) parseACLs in ZooKeeper.java fails to
parse elements of ACL, should be lastIndexOf rather than IndexOf
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-68:
---------------------------------
Attachment: colonindices.diff
> parseACLs in ZooKeeper.java fails to parse elements of ACL, should be lastIndexOf rather than IndexOf
> -----------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-68
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-68
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
> Reporter: Jakob Homan
> Priority: Minor
> Attachments: colonindices.diff
>
>
> the parseACLs(String aclString) method attempts to prase ACLs from the form of scheme:id:perm into the three components, delineated by the colons. The current version calls indexOf for both the first and second colon, receiving the same value for both and failing as if there were only one colon in the string. I created a one-line patch to call lastIndexOf for the second colon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-68) parseACLs in ZooKeeper.java fails
to parse elements of ACL, should be lastIndexOf rather than IndexOf
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611519#action_12611519 ]
Hudson commented on ZOOKEEPER-68:
---------------------------------
Integrated in ZooKeeper-trunk #16 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/16/])
> parseACLs in ZooKeeper.java fails to parse elements of ACL, should be lastIndexOf rather than IndexOf
> -----------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-68
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-68
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
> Reporter: Jakob Homan
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: colonindices.diff, ZOOKEEPER-68_1.patch
>
>
> the parseACLs(String aclString) method attempts to prase ACLs from the form of scheme:id:perm into the three components, delineated by the colons. The current version calls indexOf for both the first and second colon, receiving the same value for both and failing as if there were only one colon in the string. I created a one-line patch to call lastIndexOf for the second colon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-68) parseACLs in ZooKeeper.java fails
to parse elements of ACL, should be lastIndexOf rather than IndexOf
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-68:
-------------------------------------
Assignee: Mahadev konar
> parseACLs in ZooKeeper.java fails to parse elements of ACL, should be lastIndexOf rather than IndexOf
> -----------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-68
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-68
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
> Reporter: Jakob Homan
> Assignee: Mahadev konar
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: colonindices.diff, ZOOKEEPER-68_1.patch
>
>
> the parseACLs(String aclString) method attempts to prase ACLs from the form of scheme:id:perm into the three components, delineated by the colons. The current version calls indexOf for both the first and second colon, receiving the same value for both and failing as if there were only one colon in the string. I created a one-line patch to call lastIndexOf for the second colon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-68) parseACLs in ZooKeeper.java fails to
parse elements of ACL, should be lastIndexOf rather than IndexOf
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-68:
-----------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Status: Resolved (was: Patch Available)
I just committed this to trunk. Thanks Jakob.
> parseACLs in ZooKeeper.java fails to parse elements of ACL, should be lastIndexOf rather than IndexOf
> -----------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-68
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-68
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
> Reporter: Jakob Homan
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: colonindices.diff, ZOOKEEPER-68_1.patch
>
>
> the parseACLs(String aclString) method attempts to prase ACLs from the form of scheme:id:perm into the three components, delineated by the colons. The current version calls indexOf for both the first and second colon, receiving the same value for both and failing as if there were only one colon in the string. I created a one-line patch to call lastIndexOf for the second colon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.