[GitHub] [flink] rkhachatryan commented on a diff in pull request #19309: [FLINK-26964][state/heap] Notify CheckpointStrategy about checkpoint completion/abortion

[GitBox <gi...@apache.org>]

rkhachatryan commented on code in PR #19309:
URL: https://github.com/apache/flink/pull/19309#discussion_r916946400


##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java:
##########
@@ -333,13 +334,17 @@ public SavepointResources<K> savepoint() {
     }
 
     @Override
-    public void notifyCheckpointComplete(long checkpointId) {
-        // Nothing to do
+    public void notifyCheckpointComplete(long checkpointId) throws Exception {
+        if (checkpointStrategy instanceof CheckpointListener) {
+            ((CheckpointListener) checkpointStrategy).notifyCheckpointComplete(checkpointId);
+        }
     }
 
     @Override
-    public void notifyCheckpointAborted(long checkpointId) {
-        // nothing to do
+    public void notifyCheckpointAborted(long checkpointId) throws Exception {

Review Comment:
   You're right, it's not implemented by the strategy. But I think it would be more consistent to have it implemented here the same way as `notifyCheckpointComplete`. 
   
   WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org