You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/10/28 11:40:31 UTC
[GitHub] [nifi] UcanInfosec opened a new pull request, #6599: NIFI-10718 Update mongo.driver.version to 4.7.2
UcanInfosec opened a new pull request, #6599:
URL: https://github.com/apache/nifi/pull/6599
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-10718](https://issues.apache.org/jira/browse/NIFI-10718)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-10718) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [X] JDK 8
- [X] JDK 11
- [X] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] UcanInfosec commented on pull request #6599: NIFI-10718 Update mongo.driver.version to 4.7.2
Posted by GitBox <gi...@apache.org>.
UcanInfosec commented on PR #6599:
URL: https://github.com/apache/nifi/pull/6599#issuecomment-1294924860
@MikeThomsen thanks, much appreciated. Will look into that. But dont want to complicate things and make things harder for everyone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #6599: NIFI-10718 Update mongo.driver.version to 4.7.2
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #6599: NIFI-10718 Update mongo.driver.version to 4.7.2
URL: https://github.com/apache/nifi/pull/6599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] UcanInfosec commented on pull request #6599: NIFI-10718 Update mongo.driver.version to 4.7.2
Posted by GitBox <gi...@apache.org>.
UcanInfosec commented on PR #6599:
URL: https://github.com/apache/nifi/pull/6599#issuecomment-1295396541
@MikeThomsen @exceptionfactory Thanks. Will do. After this is merged, I will ramp it down for PR requests and commits going forward for a while.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on pull request #6599: NIFI-10718 Update mongo.driver.version to 4.7.2
Posted by GitBox <gi...@apache.org>.
MikeThomsen commented on PR #6599:
URL: https://github.com/apache/nifi/pull/6599#issuecomment-1294922079
@UcanInfosec for the kind of updates you do, there's nothing wrong with you pushing a PR that has multiple Jira tickets in it to save time on creating and reviewing the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6599: NIFI-10718 Update mongo.driver.version to 4.7.2
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6599:
URL: https://github.com/apache/nifi/pull/6599#issuecomment-1295327686
Thanks for clarifying @MikeThomsen, that makes sense. Depending on the scope of the changes, we still should be careful in terms of how many changes to include in a single PR, but I agree that some updates could be grouped together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6599: NIFI-10718 Update mongo.driver.version to 4.7.2
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6599:
URL: https://github.com/apache/nifi/pull/6599#issuecomment-1294980469
@MikeThomsen Just a note, although it creates more tickets, it is helpful to keep the updates focused on a single dependency, or directly related group of dependencies. Updating different types can create confusion and make it more difficult to review. It is a case-by-case question, but in general, I think it is better to keep the updates limited for easier review and tracking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on pull request #6599: NIFI-10718 Update mongo.driver.version to 4.7.2
Posted by GitBox <gi...@apache.org>.
MikeThomsen commented on PR #6599:
URL: https://github.com/apache/nifi/pull/6599#issuecomment-1295325482
@exceptionfactory
> Just a note, although it creates more tickets
To be clear, I said @UcanInfosec can push multiple Jira tickets in the same PR. When doing these bulk updates of dependencies, it would make more sense for @UcanInfosec/@mr1716 to do a big PR that has multiple commits, one for each Jira ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] UcanInfosec commented on pull request #6599: NIFI-10718 Update mongo.driver.version to 4.7.2
Posted by GitBox <gi...@apache.org>.
UcanInfosec commented on PR #6599:
URL: https://github.com/apache/nifi/pull/6599#issuecomment-1295099959
When I ran the actions locally, the pull request ran successfully. The JDK11 failure might need to be run again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org