You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/12/03 19:09:30 UTC

[GitHub] [cordova-android] NiklasMerz opened a new pull request #1141: remove app cache settings

NiklasMerz opened a new pull request #1141:
URL: https://github.com/apache/cordova-android/pull/1141


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   The App Cache API will soon be removed: https://web.dev/appcache-removal/
   
   The app cache methods for  `WebSettings` are another thing that get deprecated for API level 30: https://developer.android.com/reference/android/webkit/WebSettings#setAppCacheEnabled(boolean)
   
   ### Description
   <!-- Describe your changes in detail -->
   
   The app cache web API is considered deprecated and will get removed from Chrome/the Android webview around April 2021. Service workers are considered an alternative.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Unit tests
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] erisu merged pull request #1141: breaking: remove deprecated AppCache settings

Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1141:
URL: https://github.com/apache/cordova-android/pull/1141


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org