You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Gagandeep singh <ga...@gmail.com> on 2010/08/16 08:51:53 UTC
Fwd: Fixing ServletUtil.fromHttpServletRequest to take multiple
header values for same header name (issue1944044)
Reviewers: dev@shindig.apache.org
Description:
Currently ServletUtil.fromHttpServletRequest() iterates over all the
header names and add the header value returned by getHeader(headerName).
But this is buggy because getHeader() method returns only 1 header
value, which is almost always the first header value for that
headerName.
This change refactors fromHttpServletRequest() to take multiple header
values for the same header name.
Please review this at http://codereview.appspot.com/1944044/show
Affected files:
main/java/org/apache/shindig/gadgets/servlet/ServletUtil.java
test/java/org/apache/shindig/gadgets/servlet/ServletUtilTest.java
Thanks
Gagan