[GitHub] [solr] janhoy commented on pull request #984: SOLR-16340 Provide a cluster_id label for all metrics exposed by the Solr Prometheus Exporter

[GitBox <gi...@apache.org>]

janhoy commented on PR #984:
URL: https://github.com/apache/solr/pull/984#issuecomment-1239060507

   Yes I thought about choosing a static default, but the downside is of course that you always need to configure it in a multi-cluster setting, and I'm a fan of 0-config wherever practically possible.
   
   So another option could perhaps be defaulting to a hash of `zkHost` or `solrUrl`, e.g. the first 10 chars of a sha hash, which should be unique enough for this purpose. You won't be able to understand what cluster a hash is for until you select it, but at least it will always be unique. I'm ok with 'main' as well if you prefer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org